Skip to content

fix: block RCE via module denylist in YAML config loader #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aimenhamzi01-dot wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −4
Open

fix: block RCE via module denylist in YAML config loader #5682

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7dea97
fix: enable YAML denylist by default in CLI mode
aimenhamzi01-dot May 13, 2026
525fd5d
Merge pull request #1 from aimenhamzi01-dot/aimenhamzi01-dot-patch-1
aimenhamzi01-dot May 13, 2026
174d7be
fix: block RCE via module denylist in resolve_code_reference
aimenhamzi01-dot May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/google/adk/agents/config_agent_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,20 @@ def _resolve_agent_class(agent_class: str) -> type[BaseAgent]:
" BaseAgent."
)


_BLOCKED_YAML_KEYS = frozenset({"args"})
_ENFORCE_DENYLIST = False
_BLOCKED_MODULES = frozenset({
"os", "sys", "subprocess", "builtins",
"importlib", "shutil", "socket",
"ctypes", "pickle", "marshal",
})
_BLOCKED_YAML_KEYS = frozenset({
"args",
"model_code",
"tools",
"callbacks",
"input_schema",
"output_schema",
})
_ENFORCE_DENYLIST = True


def _set_enforce_denylist(value: bool) -> None:
Expand Down Expand Up @@ -214,7 +225,11 @@ def resolve_code_reference(code_config: CodeConfig) -> Any:
"""
if not code_config or not code_config.name:
raise ValueError("Invalid CodeConfig.")

top_level = code_config.name.split(".")[0]
if top_level in _BLOCKED_MODULES:
raise ValueError(
f"Module '{top_level}' is not allowed in code references."
)
module_path, obj_name = code_config.name.rsplit(".", 1)
module = importlib.import_module(module_path)
obj = getattr(module, obj_name)
Expand Down
Loading