fix: block RCE via module denylist in YAML config loader#5682
Open
aimenhamzi01-dot wants to merge 3 commits into
Open
fix: block RCE via module denylist in YAML config loader#5682aimenhamzi01-dot wants to merge 3 commits into
aimenhamzi01-dot wants to merge 3 commits into
Conversation
fix: enable YAML denylist by default in CLI mode
- Add _BLOCKED_MODULES to prevent dangerous module access - Expand _BLOCKED_YAML_KEYS to cover all dynamic code fields - Set _ENFORCE_DENYLIST = True globally Fixes RCE vulnerability via unsafe function resolution in YAML configuration loader (CVE candidate).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
resolve_code_reference()function inconfig_agent_utils.pyuses
importlibandgetattrto resolve arbitrary Python objectsfrom YAML config, allowing RCE via dangerous modules like
os.system.Solution
_BLOCKED_MODULESto block dangerous modules (os, sys,subprocess, etc.) in
resolve_code_reference()_BLOCKED_YAML_KEYSto cover all dynamic code fields_ENFORCE_DENYLIST = TruegloballyTesting
Verified that loading a YAML config with
os.systemasmodel_codenow raises
ValueErrorinstead of executing the command.Security
This fix addresses an RCE vulnerability reported via Google OSS VRP
(Reference: 506632409)