Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tmp_dir arg from AdbCallParser.__init__() + file leak fix. #228

Merged
merged 1 commit into from
Oct 8, 2024

Commits on Oct 8, 2024

  1. Remove tmp_dir arg from AdbCallParser.__init__() + file leak fix.

    This change removes an unnecessary `tmp_dir` argument from `AdbCallParser`
    which already uses `tempfile.NamedTemporaryFile()` which works in all
    situations we need. This is important because it simplifies the environment
    configuration and what needs to be passed to what during `AndroidEnv`'s
    loading, and it'll help to make it more modular.
    
    This change also fixes a bug when installing apps (i.e. `.apk` files) via
    `blob` requests where the `.apk` files were allocated and written to, but not
    deleted. These files lasted until the (successful) termination of the binary,
    and would possibly linger around if terminated abruptly.
    
    PiperOrigin-RevId: 683605810
    kenjitoyama authored and copybara-github committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    65ee54c View commit details
    Browse the repository at this point in the history