Remove tmp_dir arg from AdbCallParser.__init__() + file leak fix.
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_683411795
branch
3 times, most recently
from
10b916e
to
7a12351
Compare
This change removes an unnecessary `tmp_dir` argument from `AdbCallParser` which already uses `tempfile.NamedTemporaryFile()` which works in all situations we need. This is important because it simplifies the environment configuration and what needs to be passed to what during `AndroidEnv`'s loading, and it'll help to make it more modular. This change also fixes a bug when installing apps (i.e. `.apk` files) via `blob` requests where the `.apk` files were allocated and written to, but not deleted. These files lasted until the (successful) termination of the binary, and would possibly linger around if terminated abruptly. PiperOrigin-RevId: 683605810
copybara-service
bot
force-pushed
the
test_683411795
branch
from
7a12351
to
65ee54c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
tmp_dirarg fromAdbCallParser.__init__()+ file leak fix.This change removes an unnecessary
tmp_dirargument fromAdbCallParserwhich already uses
tempfile.NamedTemporaryFile()which works in allsituations we need. This is important because it simplifies the environment
configuration and what needs to be passed to what during
AndroidEnv'sloading, and it'll help to make it more modular.
This change also fixes a bug when installing apps (i.e.
.apkfiles) viablobrequests where the.apkfiles were allocated and written to, but notdeleted. These files lasted until the (successful) termination of the binary,
and would possibly linger around if terminated abruptly.