-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnovm): charge gas for type checking the Go AST statically #3974
base: master
Are you sure you want to change the base?
fix(gnovm): charge gas for type checking the Go AST statically #3974
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
6adc70b
to
1c96d70
Compare
0d27603
to
6109a7b
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
21b669c
to
3c43764
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments. it's good as a "naive" solution at the moment. Leave it to @thehowl for more insight, and finalize.
case *ast.UnaryExpr: | ||
atgc.consumeGas(_BASIC_TYPECHECK_GAS_CHARGE * 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I attached the comment to the base gas charge, please take a look.
Typechecking the Go abstract syntax tree incurs a huge penalty as part of the GnoVM's functionality when starting up and before running a package, hence it is only natural to also charge a cost. At first the charges shall be naive and as we expend more thought and research, shall refine what and how much to charge.
189a3aa
to
84d96d1
Compare
84d96d1
to
8516aaf
Compare
Typechecking the Go abstract syntax tree incurs a huge penalty as part of the GnoVM's functionality when starting up and before running a package, hence it is only natural to also charge a cost. At first the charges shall be naive and as we expend more thought and research, shall refine what and how much to charge.