Address review feedback and add TODOs

Author: odeke-em

gno.land/pkg/sdk/vm/gas_test.go

@@ -46,7 +46,7 @@ func TestAddPkgDeliverTxInsuffGas(t *testing.T) {
 			assert.True(t, abort)
 			assert.False(t, res.IsOK())
 			gasCheck := gctx.GasMeter().GasConsumed()
-			assert.True(t, gasCheck >= 3462)
+                        assert.Equal(t, int64(3641), gasCheck)
 		} else {
 			t.Errorf("should panic")
 		}
@@ -71,7 +71,7 @@ func TestAddPkgDeliverTx(t *testing.T) {
 	assert.True(t, res.IsOK())
 
 	// NOTE: let's try to keep this bellow 150_000 :)
-	assert.True(t, gasDeliver >= 143845)
+        assert.Equal(t, int64(144024), gasDeliver)
 }
 
 // Enough gas for a failed transaction.
@@ -88,7 +88,7 @@ func TestAddPkgDeliverTxFailed(t *testing.T) {
 	gasDeliver := gctx.GasMeter().GasConsumed()
 
 	assert.False(t, res.IsOK())
-	assert.True(t, gasDeliver >= 1231)
+        assert.Equal(t, int64(1410), gasDeliver)
 }
 
 // Not enough gas for a failed transaction.

gnovm/pkg/gnolang/gotypecheck.go

@@ -210,7 +210,7 @@ func (atgc *astTraversingGasCharger) consumeGas(amount storetypes.Gas) {
 	atgc.m.ConsumeGas(amount, "typeCheck")
 }
 
-const _BASIC_TYPECHECK_GAS_CHARGE = 5 // Arbitrary value.
+const _BASIC_TYPECHECK_GAS_CHARGE = 5 // Arbitrary value, needs more research and derivation.
 
 func (atgc *astTraversingGasCharger) Visit(n ast.Node) ast.Visitor {
 	switch n.(type) {
@@ -273,7 +273,7 @@ func (atgc *astTraversingGasCharger) Visit(n ast.Node) ast.Visitor {
 	case nil:
 		atgc.consumeGas(_BASIC_TYPECHECK_GAS_CHARGE / 2)
 
-	default:
+	default: // IndexExpr, StarExpr et al, all fall under defaults here.
 		atgc.consumeGas(_BASIC_TYPECHECK_GAS_CHARGE * 3)
 	}