Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-173: move core tests out of the SDist #217

Merged
merged 1 commit into from
Sep 16, 2024
Merged

gh-173: move core tests out of the SDist #217

merged 1 commit into from
Sep 16, 2024

Conversation

Saransh-cpp
Copy link
Member

@Saransh-cpp Saransh-cpp commented Sep 16, 2024 •
edited by github-actions bot
Loading

The core tests should be outside the SDist too. (missed this in my first PR, pointed out in #213 (comment))

Refs: #173
Reviewed-by: Nicolas Tessore

@Saransh-cpp Saransh-cpp added the maintenance Maintenance: refactoring, typos, etc. label Sep 16, 2024
@Saransh-cpp Saransh-cpp mentioned this pull request Sep 16, 2024
Merged
@Saransh-cpp Saransh-cpp merged commit 4185eaf into main Sep 16, 2024
14 checks passed
@Saransh-cpp Saransh-cpp deleted the saransh/move-core-tests branch September 16, 2024 10:54
@Saransh-cpp Saransh-cpp self-assigned this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntessore ntessore ntessore approved these changes

Assignees

@Saransh-cpp Saransh-cpp

Labels
maintenance Maintenance: refactoring, typos, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saransh-cpp @ntessore