Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-46: add infrastructure for coveralls (coverage) #213

Merged
merged 3 commits into from
Sep 16, 2024
Merged

gh-46: add infrastructure for coveralls (coverage) #213

merged 3 commits into from
Sep 16, 2024

Conversation

Saransh-cpp
Copy link
Member

@Saransh-cpp Saransh-cpp commented Sep 13, 2024 •
edited
Loading

Add code coverage in workflow using pytest-cov and coveralls.

Closes: #46
Ref: #180

@Saransh-cpp Saransh-cpp added the infrastructure Project infrastructure: dev tools, packaging, etc. label Sep 13, 2024
@ntessore
Copy link
Collaborator

Looking at the action, the coverage sees none of the lines run in glass?

(Also, the tests in glass/core/test are still in the source tree, but that's for another issue.)

@Saransh-cpp Saransh-cpp mentioned this pull request Sep 16, 2024
Merged
@ntessore
Copy link
Collaborator

This is still installing glass in the pip install step, but gathering the coverage for the glass folder in the source tree.

@Saransh-cpp
Copy link
Member Author

Works now! pytest-cov requires editable build/install. I will merge this after #217 is merged.

Saransh-cpp added a commit that referenced this pull request Sep 16, 2024
@Saransh-cpp
gh-173: move core tests out of the SDist (#217)
4185eaf 
The core tests should be outside the SDist too. (missed this in my first
PR, pointed out in
#213 (comment))

Refs: #173
Reviewed-by: Nicolas Tessore
ntessore
ntessore approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@ntessore ntessore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@Saransh-cpp Saransh-cpp merged commit 12f3265 into main Sep 16, 2024
11 checks passed
@Saransh-cpp Saransh-cpp deleted the saransh/coverage branch September 16, 2024 11:54
@Saransh-cpp Saransh-cpp self-assigned this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntessore ntessore ntessore approved these changes

Assignees

@Saransh-cpp Saransh-cpp

Labels
infrastructure Project infrastructure: dev tools, packaging, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code coverage
2 participants
@Saransh-cpp @ntessore