Skip to content

Migrate safe output handlers to config object pattern and eliminate handler-specific env vars #8019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 33 commits into from
Dec 30, 2025
Merged

Migrate safe output handlers to config object pattern and eliminate handler-specific env vars #8019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
6cc57fa
Initial plan
Copilot Dec 29, 2025
1e95458
Add safe output handler manager and tests
Copilot Dec 29, 2025
4812b36
Update test to use vitest and verify build succeeds
Copilot Dec 29, 2025
45a3a20
Add comprehensive documentation for handler manager implementation
Copilot Dec 29, 2025
4b7b51e
Process messages in order of appearance instead of grouping by type
Copilot Dec 29, 2025
d54e800
Update compiler to use handler manager and recompile workflows
Copilot Dec 29, 2025
aa45e0c
Add changeset for safe output handler manager [skip-ci]
github-actions[bot] Dec 29, 2025
7421f9d
Add add_labels, update_issue, and update_discussion to handler manager
Copilot Dec 29, 2025
a9f0dff
Fix linting issues: remove unused functions and fix ineffassign
Copilot Dec 29, 2025
3e21c30
Fix handler manager to load handlers based on config presence
Copilot Dec 29, 2025
a72e459
Add changeset [skip-ci]
github-actions[bot] Dec 29, 2025
efecb91
Add fallback config loading from environment variables
Copilot Dec 29, 2025
63d56af
Add changeset for safe output handler manager [skip-ci]
github-actions[bot] Dec 29, 2025
cd4603a
Pass handler config as JSON environment variable
Copilot Dec 29, 2025
6d1406f
Remove legacy fallback config loading logic
Copilot Dec 29, 2025
989802c
Add changeset for safe output handler manager [skip-ci]
github-actions[bot] Dec 29, 2025
b801f00
Remove enabled field and include type-specific options in handler config
Copilot Dec 29, 2025
d96e0cc
Update handler interface to accept config parameter
Copilot Dec 29, 2025
31f315c
Refactor handlers to use factory pattern with message-level processing
Copilot Dec 29, 2025
c3fa2ea
Implement factory pattern in handler manager (WIP)
Copilot Dec 29, 2025
5ea5d2b
Add changeset for safe output handler manager refactor [skip-ci]
github-actions[bot] Dec 29, 2025
d711cb6
Merge remote-tracking branch 'origin/main' into copilot/create-safe-o…
Copilot Dec 29, 2025
4ab3fc6
Add changeset [skip-ci]
github-actions[bot] Dec 29, 2025
0e286ba
Merge remote-tracking branch 'origin/main' into copilot/create-safe-o…
Copilot Dec 30, 2025
041fa45
Merge main branch
Copilot Dec 30, 2025
59eb1a9
Read add_comment configuration from config object instead of env vars
Copilot Dec 30, 2025
d05f36d
Read handler config from config object for 5 handlers
Copilot Dec 30, 2025
ebee15f
Update create_issue.cjs to use config object, remove env var generation
Copilot Dec 30, 2025
b1ffc23
Migrate GH_AW_ISSUE_ALLOWED_LABELS and GH_AW_ALLOWED_REPOS to config …
Copilot Dec 30, 2025
d0aca26
Update update_issue and update_discussion handlers to use config object
Copilot Dec 30, 2025
bb2ca75
Update create_discussion to read all config from config object
Copilot Dec 30, 2025
87b3744
Add changeset for safe-output handler migration [skip-ci]
github-actions[bot] Dec 30, 2025
29b8a0d
Remove github-token field from refactored safe output handler schemas
Copilot Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/patch-migrate-safe-output-handlers.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions .changeset/patch-safe-output-handler-manager.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 1 addition & 8 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,7 @@
"image": "mcr.microsoft.com/devcontainers/go:1-bookworm",
"customizations": {
"vscode": {
"extensions": [
"golang.go",
"GitHub.copilot-chat",
"GitHub.copilot",
"github.vscode-github-actions",
"astro-build.astro-vscode",
"DavidAnson.vscode-markdownlint"
]
"extensions": ["golang.go", "GitHub.copilot-chat", "GitHub.copilot", "github.vscode-github-actions", "astro-build.astro-vscode", "DavidAnson.vscode-markdownlint"]
},
"codespaces": {
"repositories": {
Expand Down
48 changes: 6 additions & 42 deletions .github/workflows/agent-performance-analyzer.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 6 additions & 5 deletions .github/workflows/ai-moderator.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions .github/workflows/archie.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions .github/workflows/artifacts-summary.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions .github/workflows/audit-workflows.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions .github/workflows/blog-auditor.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions .github/workflows/brave.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 6 additions & 7 deletions .github/workflows/breaking-change-checker.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading