Upgrade to go1.18.4 (vitessio#10705)

* Upgrade to Go 1.18.4

Signed-off-by: Florent Poinsard <[email protected]>

* Fix golangci-lint error in collations package

Signed-off-by: Florent Poinsard <[email protected]>

* Reverted unwanted changes to collation package

Signed-off-by: Florent Poinsard <[email protected]>

* Fix xb backup mysql80 workflow go version

Signed-off-by: Florent Poinsard <[email protected]>

.github/docker/cluster_test_12/Dockerfile

@@ -1,6 +1,6 @@
 # DO NOT MODIFY: THIS FILE IS GENERATED USING "make generate_ci_workflows"
 
-ARG bootstrap_version=9
+ARG bootstrap_version=10
 ARG image="vitess/bootstrap:${bootstrap_version}-mysql57"
 
 FROM "${image}"

.github/docker/cluster_test_18/Dockerfile

@@ -1,6 +1,6 @@
 # DO NOT MODIFY: THIS FILE IS GENERATED USING "make generate_ci_workflows"
 
-ARG bootstrap_version=9
+ARG bootstrap_version=10
 ARG image="vitess/bootstrap:${bootstrap_version}-mysql57"
 
 FROM "${image}"

.github/workflows/check_make_vtadmin_authz_testgen.yml

@@ -27,7 +27,7 @@ jobs:
       uses: actions/setup-go@v2
       if: steps.changes.outputs.vtadmin_changes == 'true'
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Tune the OS
       if: steps.changes.outputs.vtadmin_changes == 'true'

.github/workflows/check_make_vtadmin_web_proto.yml

@@ -29,7 +29,7 @@ jobs:
       uses: actions/setup-go@v2
       if: steps.changes.outputs.proto_changes == 'true'
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Setup Node
       if: steps.changes.outputs.proto_changes == 'true'

.github/workflows/cluster_endtoend_13.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_15.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_21.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_22.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_26.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_ers_prs_newfeatures_heavy.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_mysql_server_vault.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_declarative.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_declarative_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_ghost.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_ghost_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_revert.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_revert_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_revertible.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_revertible_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_scheduler.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_scheduler_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_singleton.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_singleton_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_vrepl.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_vrepl_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_vrepl_stress.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_vrepl_stress_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_vrepl_stress_suite.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_vrepl_stress_suite_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_vrepl_suite.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_onlineddl_vrepl_suite_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_schemadiff_vrepl.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_schemadiff_vrepl_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_tabletmanager_consul.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_tabletmanager_tablegc.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_tabletmanager_tablegc_mysql80.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_tabletmanager_throttler.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_tabletmanager_throttler_custom_config.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_topo_connection_cache.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_vreplication_across_db_versions.yml

@@ -43,7 +43,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_vreplication_basic.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_vreplication_cellalias.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'

.github/workflows/cluster_endtoend_vreplication_migrate_vdiff2_convert_tz.yml

@@ -42,7 +42,7 @@ jobs:
       if: steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-go@v2
       with:
-        go-version: 1.18.3
+        go-version: 1.18.4
 
     - name: Set up python
       if: steps.changes.outputs.end_to_end == 'true'