Mark aggregate functions callable (vitessio#10805)

These should also implement the iCallable interface as they are also callable as functions. Signed-off-by: Dirkjan Bussink <[email protected]>
github · Jul 25, 2022 · 059e84c · 059e84c
1 parent 8149db5
commit 059e84c
Show file tree

Hide file tree

Showing 6 changed files with 87 additions and 1 deletion.
diff --git a/go/vt/sqlparser/ast.go b/go/vt/sqlparser/ast.go
@@ -3059,6 +3059,13 @@ func (*UpdateXMLExpr) iCallable()                      {}
 func (*PerformanceSchemaFuncExpr) iCallable()          {}
 func (*GTIDFuncExpr) iCallable()                       {}
 
+func (*Sum) iCallable()       {}
+func (*Min) iCallable()       {}
+func (*Max) iCallable()       {}
+func (*Avg) iCallable()       {}
+func (*CountStar) iCallable() {}
+func (*Count) iCallable()     {}
+
 func (sum *Sum) GetArg() Expr                   { return sum.Arg }
 func (min *Min) GetArg() Expr                   { return min.Arg }
 func (max *Max) GetArg() Expr                   { return max.Arg }

diff --git a/go/vt/sqlparser/ast_clone.go b/go/vt/sqlparser/ast_clone.go
diff --git a/go/vt/sqlparser/ast_equals.go b/go/vt/sqlparser/ast_equals.go
diff --git a/go/vt/sqlparser/ast_rewrite.go b/go/vt/sqlparser/ast_rewrite.go
diff --git a/go/vt/sqlparser/ast_visit.go b/go/vt/sqlparser/ast_visit.go
diff --git a/go/vt/vtgate/engine/cached_size.go b/go/vt/vtgate/engine/cached_size.go