fix: temporary fix to bgp neigh update-source #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2025
|
dev.yml workflow with nightly toolchain is expected to fail until we merge #493 or some equivalent fix. |
|
Marking this as no-merge since the work-around will not work with the current config in Fabric. |
Fredi-raspall
force-pushed
the
pr/fredi/temp_workaround_bgp_neigh_update_source
branch
from
67f8669 to
7b439a6
Compare
The fix hard-codes the name of the loopback interface and should be replaced by a proper method that uses the information coming from the gRPC config model. Signed-off-by: Fredi Raspall <[email protected]>
Fredi-raspall
force-pushed
the
pr/fredi/temp_workaround_bgp_neigh_update_source
branch
from
7b439a6 to
1a3652a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix to bgp neigh update-source
The fix hard-codes the name of the loopback interface and should be replaced by a proper method that uses the information coming from the gRPC config model.
See: https://github.com/githedgehog/gateway-proto/compare/pr/fredi/augment-proto-bgp-update-source?expand=1