Augment model with BGP neighbor update source #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed for preview.
The conversion from gRPC in dataplane is not correct as it uses the neighbor address to set the update source address towards the neighbor. In order to fix this, the gRPC protobuf schema should allow setting this. This patch augments the protobuf schema with such a field.
The issue explains why we were seeing things like:
... because the config generated for FRR was:
which is incorrect.
In dataplane, this is temporarily fixed by githedgehog/dataplane#498