Skip to content

Update codespan-reporting to 0.12 #7398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

Update codespan-reporting to 0.12 #7398

merged 3 commits into from
Mar 26, 2025

Conversation

bushrat011899
Copy link
Contributor

Connections

Description

  • Bumped codespan-reporting to 0.12, which adds no_std support

Testing

  • CI

Squash or Rebase?

Squash (assuming I may need to submit follow-up commits)

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@bushrat011899 bushrat011899 requested a review from a team as a code owner March 23, 2025 06:22
waywardmonkeys
waywardmonkeys reviewed Mar 24, 2025
View reviewed changes
@bushrat011899 bushrat011899 mentioned this pull request Mar 24, 2025
Closed
ErichDonGubler
ErichDonGubler previously requested changes Mar 25, 2025
View reviewed changes
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but…

@ErichDonGubler
Copy link
Member

Just vetted codespan-reporting 0.12.0 on Mozilla's end, and am landing the cargo vet audit now: D242995

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) March 26, 2025 02:05
@cwfitzgerald cwfitzgerald merged commit 175b66c into gfx-rs:trunk Mar 26, 2025
37 checks passed
@ErichDonGubler
Copy link
Member

LGTM now! 😀👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys left review comments

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

@ErichDonGubler ErichDonGubler Awaiting requested review from ErichDonGubler

Assignees

@ErichDonGubler ErichDonGubler

@cwfitzgerald cwfitzgerald

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bushrat011899 @ErichDonGubler @waywardmonkeys @cwfitzgerald