Skip to content

Commit 175b66c

Browse files
Update codespan-reporting to 0.12 (#7398)
* Update `codespan-reporting` to 0.12 * Use explicit path for `term::termcolor` * Revert changes to `Cargo.lock`
1 parent 7b6ff5f commit 175b66c

File tree

9 files changed

+18
-16
lines changed

9 files changed

+18
-16
lines changed

Cargo.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ cargo_metadata = "0.19"
9898
cfg_aliases = "0.2.1"
9999
cfg-if = "1"
100100
criterion = "0.5"
101-
codespan-reporting = "0.11"
101+
codespan-reporting = { version = "0.12", default-features = false }
102102
ctor = "0.2"
103103
document-features = "0.2.11"
104104
encase = "0.10.0"

naga-cli/Cargo.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ naga = { workspace = true, features = [
4040
] }
4141

4242
bincode.workspace = true
43-
codespan-reporting.workspace = true
43+
codespan-reporting = { workspace = true, default-features = false, features = [
44+
"std",
45+
"termcolor",
46+
] }
4447
env_logger.workspace = true
4548
argh.workspace = true
4649
anyhow = { workspace = true, features = ["std"] }

naga/Cargo.toml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,10 @@ arbitrary = { version = "1.4", features = ["derive"], optional = true }
8585
arrayvec.workspace = true
8686
bitflags.workspace = true
8787
bit-set.workspace = true
88-
termcolor = { version = "1.4.1" }
89-
# remove termcolor dep when updating to the next version of codespan-reporting
90-
# termcolor minimum version was wrong and was fixed in
91-
# https://github.com/brendanzab/codespan/commit/e99c867339a877731437e7ee6a903a3d03b5439e
92-
codespan-reporting = { version = "0.11.0" }
88+
codespan-reporting = { workspace = true, default-features = false, features = [
89+
"std",
90+
"termcolor",
91+
] }
9392
hashbrown.workspace = true
9493
half = { workspace = true, features = ["arbitrary", "num-traits"] }
9594
rustc-hash.workspace = true

naga/src/error.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ impl fmt::Display for ShaderError<crate::WithSpan<crate::valid::ValidationError>
4040
let label = self.label.as_deref().unwrap_or_default();
4141
let files = SimpleFile::new(label, &self.source);
4242
let config = term::Config::default();
43-
let mut writer = termcolor::NoColor::new(Vec::new());
43+
let mut writer = term::termcolor::NoColor::new(Vec::new());
4444
term::emit(&mut writer, &config, &files, &self.inner.diagnostic())
4545
.expect("cannot write error");
4646
write!(

naga/src/front/glsl/error.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ use alloc::{
88
use codespan_reporting::diagnostic::{Diagnostic, Label};
99
use codespan_reporting::files::SimpleFile;
1010
use codespan_reporting::term;
11+
use codespan_reporting::term::termcolor::{NoColor, WriteColor};
1112
use pp_rs::token::PreprocessorError;
12-
use termcolor::{NoColor, WriteColor};
1313
use thiserror::Error;
1414

1515
use super::token::TokenValue;

naga/src/front/spv/error.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use alloc::{
77
use codespan_reporting::diagnostic::Diagnostic;
88
use codespan_reporting::files::SimpleFile;
99
use codespan_reporting::term;
10-
use termcolor::{NoColor, WriteColor};
10+
use codespan_reporting::term::termcolor::{NoColor, WriteColor};
1111

1212
use super::ModuleState;
1313
use crate::{arena::Handle, front::atomic_upgrade};

naga/src/front/wgsl/error.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ use super::parse::lexer::Token;
1414
use codespan_reporting::diagnostic::{Diagnostic, Label};
1515
use codespan_reporting::files::SimpleFile;
1616
use codespan_reporting::term;
17-
use termcolor::{ColorChoice, NoColor, StandardStream};
17+
use codespan_reporting::term::termcolor::{ColorChoice, NoColor, StandardStream};
1818
use thiserror::Error;
1919

2020
use alloc::{

naga/src/span.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,8 +285,8 @@ impl<E> WithSpan<E> {
285285
where
286286
E: Error,
287287
{
288+
use codespan_reporting::term::termcolor::{ColorChoice, StandardStream};
288289
use codespan_reporting::{files, term};
289-
use term::termcolor::{ColorChoice, StandardStream};
290290

291291
let files = files::SimpleFile::new(path, source);
292292
let config = term::Config::default();
@@ -308,8 +308,8 @@ impl<E> WithSpan<E> {
308308
where
309309
E: Error,
310310
{
311+
use codespan_reporting::term::termcolor::NoColor;
311312
use codespan_reporting::{files, term};
312-
use term::termcolor::NoColor;
313313

314314
let files = files::SimpleFile::new(path, source);
315315
let config = term::Config::default();

0 commit comments

Comments
 (0)