Feat/bulk methylation templates #80
Conversation
anngvu
commented
Nov 28, 2023
•
anngvu
commented
- Close Import bisulfite-sequencing template (level 2/3) #67: Added templates based on HTAN version, but removed a couple of optional attributes to keep more streamlined.
- Also throw in Add the dca-template-config.json to this repo and use for testing #79: Easier testing, prepare us for new December setup.
Test Suite ReportTemplate Generation
Manifest ValidationTODO |
anngvu
force-pushed
the
feat/bulk-methylation-templates
branch
from
7ff8682 to
9c6da66
Compare
| @@ -1,15 +1,23 @@ | |||
| classes: | |||
|
|
|||
| Sequencing: | |||
| File: | |||
There was a problem hiding this comment.
Wondering if we want to change imaging to inherit from "File" as well.
There was a problem hiding this comment.
Might not be as easy as I think though..
There was a problem hiding this comment.
OK after trial and errors..I just changed LabID to ParticipantID to be consistent with the other templates..I think that's all for now -
General question on the inheriting - Can we do "is_a" across different yaml files? (Like have imaging inherit from File if it's in another yaml file?)
There was a problem hiding this comment.
OK, thanks for updating LabID to make it more consistent. Yep, can do is_a across different files.
There was a problem hiding this comment.
We'll apply the refactoring for imaging in another PR to keep this one smaller.
remove LabID since it's duplicated by ParticipantID
