Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the dca-template-config.json to this repo and use for testing #79

Closed
anngvu opened this issue Nov 28, 2023 · 0 comments · Fixed by #80
Closed

Add the dca-template-config.json to this repo and use for testing #79

anngvu opened this issue Nov 28, 2023 · 0 comments · Fixed by #80
Assignees
@anngvu

Comments

@anngvu
Copy link
Contributor

anngvu commented Nov 28, 2023

In this Slack announcement, D&T announced that we can maintain the templates config.json somewhere and DCA will reference the link (probably because keeping on top of PRs to update configs for 10+ DCCs is a lot of work):

For the next release of DCA in mid-December we are going to switch to new config files
...
the template dropdown config and logo will be referenced by a URL, not the filepath in data_curator_config. This means those files can live elsewhere, like your data model repo.
@anngvu anngvu self-assigned this Nov 28, 2023
@anngvu anngvu moved this to In Progress in Gray Foundation Development Nov 28, 2023
@anngvu anngvu changed the title Add the templates config.json to this repo and use for testing Add the dca-templates-config.json to this repo and use for testing Nov 28, 2023
@anngvu anngvu changed the title Add the dca-templates-config.json to this repo and use for testing Add the dca-template-config.json to this repo and use for testing Nov 28, 2023
anngvu added a commit that referenced this issue Nov 28, 2023
@anngvu
Copy over current dca-template-config.json per #79
a30ab85
@anngvu anngvu mentioned this issue Nov 28, 2023
Merged
@anngvu anngvu linked a pull request Nov 28, 2023 that will close this issue
Feat/bulk methylation templates #80
Merged
anngvu added a commit that referenced this issue Nov 29, 2023
@anngvu @gf-dcc-service @cconrad8
Feat/bulk methylation templates (#80)
d53bda4 
* Add BulkMethylation-seq templates for more levels

* Add kit enum

* Add more enums

* Add slots

* Cleanup

* Lint stray tabs

* Refactor

* Cleanup

* Copy over current dca-template-config.json per #79

* Add bulk methylation-seq templates to templates config

* Lint

* Update README

* Update test

* Update README

* Remove unneeded step of setting up remote config in test

* Use ParentDataFileID

* Wording

* Increase throttle setting

* Build jsonld

* Fix

* Update throttle parameter again

* Build jsonld

* Fix extra spaces

* More cleanup

* Build jsonld

* Update imaging.yaml

* Build jsonld

* Update slots.yaml

remove LabID since it's duplicated by ParticipantID

* Build jsonld

* Update imaging.yaml

* Build jsonld

* Update imaging.yaml

* Update imaging.yaml

* Build jsonld

* Update imaging.yaml

* Update imaging.yaml

* change to participantID

* Build jsonld

---------

Co-authored-by: gf-dcc-service <[email protected]>
Co-authored-by: Christina Conrad <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Gray Foundation Development Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anngvu anngvu

Labels
None yet
Projects
Gray Foundation Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/bulk methylation templates gf-dcc/data-model
1 participant
@anngvu