fix(workflow-engine): Reject boolean deescalation comparisons - #124304
Merged
Merged
Conversation
Co-Authored-By: Kyle Consalus <kyle.consalus@sentry.io>
github-actions
Bot
added
the
Scope: Backend
kcons
marked this pull request as ready for review
September 14, 2026 18:23
kcons
added a commit
that referenced
this pull request
Sep 15, 2026
…124309) Add a post-deployment data migration that replaces stored boolean `true` comparisons for issue-priority de-escalation conditions with the high-priority threshold (`75`). Other condition types and existing numeric thresholds are left unchanged. Note that due to caches, we may still be using these for up to 4 hours after the migration, but considering how rare and already-broken these cases are, that's acceptable vs the complexity of invalidation. Refs ISWF-3453 and ISWF-3455. To be merged after #124304 so we know the door is closed to new violations. <!-- junior-request-attribution:start --> via **Kyle Consalus**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AD0BT0DUS6SX%3A1789408419.672829 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AD0BT0DUS6SX%3A1789408419.672829) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AD0BT0DUS6SX%3A1789408419.672829/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Kyle Consalus <kyle.consalus@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject boolean comparisons for issue-priority de-escalation conditions now that the automation builder sends an explicit priority. Keep evaluation compatible with existing stored boolean comparisons until the follow-up data migration lands.
Refs ISWF-3453.
via Kyle Consalus.
--
View Junior Session [Sentry]