Skip to content

migration(workflow-engine): Replace boolean deescalation comparisons - #124309

Merged
kcons merged 6 commits into
masterfrom
migration/iswf-3453-deescalation-booleans-to-high
Sep 15, 2026
Merged

kcons merged 6 commits into
masterfrom
migration/iswf-3453-deescalation-booleans-to-high

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Add a post-deployment data migration that replaces stored boolean true comparisons for issue-priority de-escalation conditions with the high-priority threshold (75). Other condition types and existing numeric thresholds are left unchanged.

Note that due to caches, we may still be using these for up to 4 hours after the migration, but considering how rare and already-broken these cases are, that's acceptable vs the complexity of invalidation.

Refs ISWF-3453 and ISWF-3455.

To be merged after #124304 so we know the door is closed to new violations.

via Kyle Consalus.

--

View Junior Session [Sentry]

Co-Authored-By: Kyle Consalus <kyle.consalus@sentry.io>
@linear-code

linear-code Bot commented Sep 14, 2026

Copy link
Copy Markdown

ISWF-3453

ISWF-3455

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0120_replace_boolean_deescalation_comparisons.py

for 0120_replace_boolean_deescalation_comparisons in workflow_engine

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

@kcons

kcons commented Sep 14, 2026

Copy link
Copy Markdown
Member

bugbot review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@kcons
kcons marked this pull request as ready for review September 14, 2026 19:03
@kcons
kcons requested a review from a team as a code owner September 14, 2026 19:03
@kcons
kcons requested a review from saponifi3d September 14, 2026 20:05

@saponifi3d saponifi3d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, just a little nervous about the unindexed column with the issue from ~2 weeks ago.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fb1b80f. Configure here.

@kcons
kcons enabled auto-merge (squash) September 15, 2026 17:26
@kcons
kcons merged commit e1e45c1 into master Sep 15, 2026
89 of 90 checks passed
@kcons
kcons deleted the migration/iswf-3453-deescalation-booleans-to-high branch September 15, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants