Skip to content

fix(settings): Close member dropdown before invite modal #121005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scttcper wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −3
Open

fix(settings): Close member dropdown before invite modal #121005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions static/app/views/settings/organizationTeams/teamMembers.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ describe('TeamMembers', () => {
await userEvent.click(screen.getByTestId('invite-member'));

expect(openInviteMembersModal).toHaveBeenCalled();
expect(screen.queryByTestId('invite-member')).not.toBeInTheDocument();
});

it('can invite member from team dropdown with access and `Open Membership` enabled', async () => {
Expand Down
9 changes: 6 additions & 3 deletions static/app/views/settings/organizationTeams/teamMembers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,14 +155,17 @@ function AddMemberDropdown({
memberId: selection.value,
})
}
menuFooter={
menuFooter={({closeOverlay}) => (
<MenuComponents.CTAButton
onClick={() => openInviteMembersModal({source: 'teams'})}
onClick={() => {
closeOverlay();
openInviteMembersModal({source: 'teams'});
}}
data-test-id="invite-member"
>
{t('Invite Member')}
</MenuComponents.CTAButton>
}
)}
data-test-id="add-member-menu"
disabled={isDropdownDisabled}
menuTitle={t('Members')}
Expand Down
Loading