fix(settings): Close member dropdown before invite modal - #121005
Open
scttcper wants to merge 1 commit into
Open
fix(settings): Close member dropdown before invite modal#121005scttcper wants to merge 1 commit into
scttcper wants to merge 1 commit into
Conversation
The member dropdown kept its contained focus scope active while the invite modal opened its own focus trap. The two scopes could fight over focus and freeze the page. Close the dropdown first and assert that it is removed when the invite action runs. Co-Authored-By: Codex <noreply@openai.com>
scttcper
marked this pull request as ready for review
July 31, 2026 20:43
scttcper
added a commit
that referenced
this pull request
Jul 31, 2026
Opening Invite Member from the assignee selector left the menu's focus scope active while the global modal created a second focus trap. That can bounce focus between both overlays and freeze the page. Close the assignee menu before launching the modal, matching #121005. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening Invite Member from the Add Member menu left the menu's contained focus scope active while the modal created a second focus trap. They could bounce focus between each other and freeze the page.
Close the menu before opening the modal and cover the behavior in the team members test.
steps to reproduce:
fixes JAVASCRIPT-3B6A