backend: allow configuring S3_REGION #870
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ____TODO____, closes getodk#846
alxndrsn
changed the title
alxndrsn
pushed a commit
to alxndrsn/odk-docs
that referenced
this pull request
Jan 13, 2025
alxndrsn
pushed a commit
to alxndrsn/odk-central-backend
that referenced
this pull request
Jan 13, 2025
This was referenced Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With getodk/central-backend#1357 & getodk/docs#1912, closes #846
What has been done to verify that this works as intended?
e2e tests in central-backend. Suggestions for higher-level tests appreciated!
Why is this the best possible solution? Were any other approaches considered?
It seems simple and in-line with existing s3 configuration.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should not have a direct effect on users, although changes to central-backend may.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
See linked PR for https://github.com/getodk/docs/
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)