backend: allow configuring S3_REGION #1357
Open
+129
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
alxndrsn
commented
Jan 13, 2025
|
|
||
| // given | ||
| // randomise attDir to ensure re-runs do not use the same generated files | ||
| await setup(0, { bigFiles: 1, bigFileSizeMb: 0.01, attDir: tmp.dirSync().name }); |
There was a problem hiding this comment.
rename bigFiles to randomFiles?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: getodk/central#870
What has been done to verify that this works as intended?
A new, very simple e2e test has been added, and it's run multiple times with different config.
Why is this the best possible solution? Were any other approaches considered?
It's simple, and there are no obvious alternatives.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Allows users to configure regions. Should not have impact if region is not specified.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Yes: getodk/docs#1912
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes