Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: count all matches in total #446

Merged
merged 5 commits into from
Aug 6, 2024
Merged

feat: count all matches in total #446

merged 5 commits into from
Aug 6, 2024

Conversation

morgante
Copy link
Contributor

@morgante morgante commented Aug 6, 2024

Summary by CodeRabbit

  • New Features

    • Added a method to retrieve range information from match results, enhancing data accessibility.
    • Introduced new fields to track processed files and matches in the processing summary.
  • Improvements

    • Enhanced clarity in documentation for match count fields.
    • Updated match counting logic to accurately reflect the number of found ranges, improving data precision.
  • Tests

    • Adjusted test assertions to reflect updated expectations for match counts and file outputs.

@morgante morgante requested a review from a team as a code owner August 6, 2024 18:58
Copy link
Contributor

coderabbitai bot commented Aug 6, 2024

Walkthrough

Walkthrough

The recent changes enhance the functionality of the MatchResult and AllDone structures by adding a method for retrieving ranges and introducing new fields to track processing metrics. Modifications to the ApplyDetails struct clarify the purpose of the matched field and improve match counting logic in the Messager trait. Additionally, test assertions have been refined to reflect updated expectations, ensuring better alignment with the code's functionality.

Changes

Files Change Summary
crates/core/src/api.rs Updated MatchResult to add a new method get_ranges for retrieving range information; added processed and found fields to AllDone for tracking processing metrics.
crates/marzano_messenger/src/emit.rs Added documentation for the matched field in ApplyDetails and refined logic in the Messager trait to accurately count matches based on range presence instead of a constant increment.
crates/cli_bin/tests/apply.rs Modified assertions in tests to reflect updated expectations for match counts in the filtered_apply, overrides_limit, and applies_on_file_in_hidden_directory functions.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3ce4e85 and 7dfba01.

Files selected for processing (1)
  • crates/cli_bin/tests/apply.rs (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • crates/cli_bin/tests/apply.rs
Additional context used
Learnings (1)
Common learnings
Learnt from: morgante
URL: https://github.com/getgrit/gritql/pull/231

Timestamp: 2024-04-15T05:47:47.743Z
Learning: User morgante prefers not to be asked for documentation.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

grit-app bot commented Aug 6, 2024

View earlier commits On commit cba2f70, Grit tried to heal these tests:
Job Original Status Final Status
main / Rust tests (marzano) ❌ Failed ❗ Failed on attempt #3 after trying strategies ai, rerun

On commit 421d504, Grit tried to heal these tests:

Job Original Status Final Status
main / Rust tests (marzano) ❌ Failed ❗ Failed on attempt #3 after trying strategies ai, rerun

On commit 3ce4e85, Grit tried to heal these tests:

Job Original Status Final Status
main / Rust tests (marzano) ❌ Failed ❗ Failed on attempt #3 after trying strategies ai, rerun

Tip

You can view and edit CI healing settings on the Grit App.

@morgante morgante merged commit c206ec2 into main Aug 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants