feat: make a minimum match of 1 for counting

[morgante]

Otherwise results look very odd, follow up to #446

Summary by CodeRabbit

• Bug Fixes

  • Improved the calculation of matched details to enhance accuracy and efficiency.
  • Ensured that details.matched always reflects at least one match when no ranges are found.

• New Features

  • Updated the API endpoint for backend interactions, improving connectivity with services.

• Refactor

  • Streamlined logic for determining matched ranges, improving code clarity and maintainability.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes improve the Messager trait implementation by streamlining the calculation of matched details from the execution_result. The previous explicit checks for ranges have been replaced with a more concise approach that utilizes functional programming concepts. This enhances code clarity and efficiency while maintaining the existing logic for counting rewritten matches. Additionally, the API URL used in the application has been updated, impacting backend service interactions.

Changes

File Path	Change Summary
crates/marzano_messenger/src/emit.rs	Simplified the calculation of details.matched using map and unwrap_or. Logic for details.rewritten remains unchanged.
crates/auth/src/env.rs	Updated DEFAULT_GRIT_API_URL to a new endpoint (https://api2.grit.io), affecting API interactions.

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dc51c4f and c4ffef3.

Files selected for processing (1)

• crates/auth/src/env.rs (1 hunks)

Additional context used

Learnings (1)

Common learnings

Learnt from: morgante
URL: https://github.com/getgrit/gritql/pull/231

Timestamp: 2024-04-15T05:47:47.743Z
Learning: User morgante prefers not to be asked for documentation.

Additional comments not posted (1)

crates/auth/src/env.rs (1)

8-8: Verify the new API URL.

The DEFAULT_GRIT_API_URL has been updated to https://api2.grit.io. Ensure that this new URL is correct and that all systems relying on this endpoint are updated accordingly. Additionally, verify that any related documentation reflects this change.

Verification successful

---

New API URL Verified

The new API URL https://api2.grit.io has been correctly updated in the codebase, replacing the old URL. Ensure that all external systems and documentation are updated to reflect this change.

• crates/auth/src/env.rs: Updated DEFAULT_GRIT_API_URL.
• crates/auth/src/auth0.rs: Updated AUTH0_API_AUDIENCE.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify references to the old and new API URLs in the codebase.

# Test: Search for occurrences of the old API URL. Expect: No occurrences.
rg --type rust 'https://api-gateway-prod-6et7uue.uc.gateway.dev'

# Test: Search for occurrences of the new API URL. Expect: Matches in relevant files.
rg --type rust 'https://api2.grit.io'

Length of output: 300

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.