-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #11: Install XHProf from source #12
Conversation
We should also add docker tests here so we can verify the paths exist. I changed so both RedHat and Debian places the lib/html directories in the same location. Also nice that these variables actually do something now. |
Good idea. We also need to set a default |
24fd7b4
to
50e21c6
Compare
Okay apparently the hour is too late for me, I keep making odd typos everywhere. I'll work further on this tomorrow. |
Sounds good. I'm fading fast, too. |
Same galaxy error as on Drupal VM |
702387f
to
6bfdd21
Compare
a901aba
to
c7750a3
Compare
ccdfe5b
to
68f8836
Compare
Tests are passing! I must admit I was expecting something more, but I verified that the autocomplete and the tooltips now work :) I'm building it using ansible from pip on Centos as the php role installation still fails ansible/galaxy-issues#134 (comment). |
Issue #11: Install XHProf from source
+1 on this PR -- the pear module still seems to have idempotency issues. |
Haven't really tested, but lets see what travis says. Should add tests or at least verify that the lib and ui directories are in place and working.