Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #11: Install XHProf from source #12

Merged
merged 10 commits into from
Mar 1, 2016
Merged

Conversation

oxyc
Copy link
Contributor

@oxyc oxyc commented Feb 29, 2016

Haven't really tested, but lets see what travis says. Should add tests or at least verify that the lib and ui directories are in place and working.

@oxyc
Copy link
Contributor Author

oxyc commented Feb 29, 2016

We should also add docker tests here so we can verify the paths exist. I changed so both RedHat and Debian places the lib/html directories in the same location. Also nice that these variables actually do something now.

@geerlingguy
Copy link
Owner

Good idea. We also need to set a default workspace variable so the tests can work.

@oxyc oxyc force-pushed the source branch 2 times, most recently from 24fd7b4 to 50e21c6 Compare February 29, 2016 05:04
@oxyc
Copy link
Contributor Author

oxyc commented Feb 29, 2016

Okay apparently the hour is too late for me, I keep making odd typos everywhere. I'll work further on this tomorrow.

@geerlingguy
Copy link
Owner

Sounds good. I'm fading fast, too.

@oxyc
Copy link
Contributor Author

oxyc commented Feb 29, 2016

Same galaxy error as on Drupal VM

@oxyc oxyc force-pushed the source branch 6 times, most recently from 702387f to 6bfdd21 Compare March 1, 2016 14:51
@oxyc oxyc force-pushed the source branch 2 times, most recently from a901aba to c7750a3 Compare March 1, 2016 15:28
@oxyc oxyc force-pushed the source branch 2 times, most recently from ccdfe5b to 68f8836 Compare March 1, 2016 16:05
@oxyc
Copy link
Contributor Author

oxyc commented Mar 1, 2016

Tests are passing! I must admit I was expecting something more, but I verified that the autocomplete and the tooltips now work :)

I'm building it using ansible from pip on Centos as the php role installation still fails ansible/galaxy-issues#134 (comment).

This PR resolves: #11, #8 and partly #7.

geerlingguy added a commit that referenced this pull request Mar 1, 2016
Issue #11: Install XHProf from source
@geerlingguy geerlingguy merged commit eab43ed into geerlingguy:master Mar 1, 2016
@thom8
Copy link
Contributor

thom8 commented Mar 1, 2016

+1 on this PR -- the pear module still seems to have idempotency issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants