Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing xhprof_html assets in PECL installation #11

Closed
oxyc opened this issue Feb 28, 2016 · 2 comments
Closed

Missing xhprof_html assets in PECL installation #11

oxyc opened this issue Feb 28, 2016 · 2 comments

Comments

@oxyc
Copy link
Contributor

oxyc commented Feb 28, 2016

See phacility/xhprof#64, geerlingguy/drupal-vm#91 and https://bugs.php.net/bug.php?id=65992.

Doesnt seem likely this will be fixed upstream. Guess there are two options:

  1. Install from source https://github.com/phacility/xhprof/blob/master/xhprof_html/docs/index.html#L289:L294
  2. Fetch the assets from github and extract them into xhprof_html

If we go with 1 this could also be made to solve #2.
@oxyc oxyc changed the title Missing assets in xhprof_html Missing xhprof_html assets in PECL installation Feb 28, 2016
@geerlingguy
Copy link
Owner

:(

Yeah, I was just thinking about this a couple weeks ago. I'm thinking we go with source install. We can model the source install after the almost-identical install for php-xdebug https://github.com/geerlingguy/ansible-role-php-xdebug

oxyc added a commit to oxyc/ansible-role-php-xhprof that referenced this issue Feb 29, 2016
@oxyc
Issue geerlingguy#11: Install XHProf from source
d027c8e
oxyc added a commit to oxyc/ansible-role-php-xhprof that referenced this issue Feb 29, 2016
@oxyc
Issue geerlingguy#11: Install XHProf from source
3746feb
oxyc added a commit to oxyc/ansible-role-php-xhprof that referenced this issue Feb 29, 2016
@oxyc
Issue geerlingguy#11: Install XHProf from source
5a1715c
oxyc added a commit to oxyc/ansible-role-php-xhprof that referenced this issue Mar 1, 2016
@oxyc
Issue geerlingguy#11: Install XHProf from source
08d8bf2
@oxyc oxyc mentioned this issue Mar 1, 2016
Merged
geerlingguy added a commit that referenced this issue Mar 1, 2016
@geerlingguy
Merge pull request #12 from oxyc/source
eab43ed 
Issue #11: Install XHProf from source
@geerlingguy
Copy link
Owner

Fixed in #12

@oxyc oxyc mentioned this issue Mar 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oxyc @geerlingguy