Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to modify globals without store #3

Closed
wants to merge 16 commits into from
Closed

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Jul 15, 2023

Also ignore new clippy lint

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2023

Codecov Report

Patch coverage: 80.64% and project coverage change: +0.19% 🎉

Comparison is base (c8b0be9) 79.04% compared to head (5da04cb) 79.23%.

Additional details and impacted files
@@               Coverage Diff                @@
##           gear-v0.30.0       #3      +/-   ##
================================================
+ Coverage         79.04%   79.23%   +0.19%     
================================================
  Files               104      105       +1     
  Lines              8823     8852      +29     
================================================
+ Hits               6974     7014      +40     
+ Misses             1849     1838      -11     
Files Changed Coverage Δ
crates/wasmi/src/global.rs 44.73% <0.00%> (+0.58%) ⬆️
crates/wasmi/src/store.rs 79.58% <75.00%> (+0.08%) ⬆️
crates/wasmi/src/patches.rs 85.71% <85.71%> (ø)
crates/wasmi/src/engine/cache.rs 81.25% <100.00%> (+0.89%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ark0f ark0f changed the title Allow to modify globals and read exports without store Allow to modify globals without store Jul 19, 2023
@ark0f ark0f force-pushed the al-modify-globals branch 3 times, most recently from 130b6d6 to ecdd8ba Compare July 19, 2023 21:18
crates/wasmi/src/patches.rs Show resolved Hide resolved
crates/wasmi/src/patches.rs Show resolved Hide resolved
crates/wasmi/src/patches.rs Outdated Show resolved Hide resolved
crates/wasmi/src/patches.rs Outdated Show resolved Hide resolved
@ark0f
Copy link
Member Author

ark0f commented Aug 2, 2023

Closed. More at gear-tech/gear#3017

@ark0f ark0f closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants