Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sandbox): Update WASMI in gear-sandbox #2931

Closed
wants to merge 10 commits into from

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Jul 12, 2023

@ark0f ark0f added A0-pleasereview PR is ready to be reviewed by the team D1-core Gear Core labels Jul 12, 2023
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

sandbox/host/src/sandbox.rs Outdated Show resolved Hide resolved
@ark0f ark0f added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Jul 12, 2023
@ark0f
Copy link
Member Author

ark0f commented Jul 12, 2023

Got issues:

   0: backtrace::capture::Backtrace::create
   1: backtrace::capture::Backtrace::new
   2: sp_panic_handler::set::{{closure}}
   3: <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call
             at /rustc/f5559e338256f17ada6d82b429acc2dbd8facc9c/library/alloc/src/boxed.rs:1976:9
      std::panicking::rust_panic_with_hook
             at /rustc/f5559e338256f17ada6d82b429acc2dbd8facc9c/library/std/src/panicking.rs:704:13
   4: std::panicking::begin_panic_handler::{{closure}}
             at /rustc/f5559e338256f17ada6d82b429acc2dbd8facc9c/library/std/src/panicking.rs:595:13
   5: std::sys_common::backtrace::__rust_end_short_backtrace
             at /rustc/f5559e338256f17ada6d82b429acc2dbd8facc9c/library/std/src/sys_common/backtrace.rs:150:18
   6: rust_begin_unwind
             at /rustc/f5559e338256f17ada6d82b429acc2dbd8facc9c/library/std/src/panicking.rs:584:5
   7: core::panicking::panic_fmt
             at /rustc/f5559e338256f17ada6d82b429acc2dbd8facc9c/library/core/src/panicking.rs:67:14
   8: core::result::unwrap_failed
             at /rustc/f5559e338256f17ada6d82b429acc2dbd8facc9c/library/core/src/result.rs:1651:5
   9: gear_sandbox_host::sandbox::SandboxInstance::get_global_val
  10: core::ops::function::FnOnce::call_once
  11: tracing::span::Span::in_scope
  12: gear_runtime_interface::gear_sandbox::sandbox::ExtSandboxGetGlobalValVersion1::call
  13: <sc_executor_wasmtime::imports::Registry as sp_wasm_interface::HostFunctionRegistry>::with_function_context
  14: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
  15: wasmtime::func::Caller<T>::with
  16: <F as wasmtime::func::IntoFunc<T,(wasmtime::func::Caller<T>,A1,A2),R>>::into_func::wasm_to_host_shim
  17: <unknown>


Thread 'tokio-runtime-worker' panicked at 'already mutably borrowed: BorrowError', sandbox/host/src/sandbox.rs:235

@ark0f ark0f added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed and removed A3-gotissues PR occurred to have issues after the review labels Jul 17, 2023
@ark0f ark0f mentioned this pull request Aug 2, 2023
4 tasks
@ark0f
Copy link
Member Author

ark0f commented Aug 2, 2023

Closed as there is no good solution. More at #3017

@ark0f ark0f closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D1-core Gear Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants