-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URDF -> SDFormat: empty links should be converted to frames. #262
Comments
Related issue: #199 . |
Thanks! |
Also, meta: Is it possible to word issues in such a way that they're not ambiguous with PR titles? (I'm guessing this is from the Asana transition, prolly the title I wrote; I used less "issue title" hygiene in Asana 😅 ) |
there's a lot of discussion in #199; I'd prefer to close this and add these comments there |
SGTM. |
Closed in favor of #199 |
It is common to create empty links to represent frames in URDF. However, when converting URDF to SDFormat, such links are ignored because they have zero mass. While this is fine for simulation, the frame information represented by empty links is lost.
Now that frames are supported in SDFormat, we should create a frame for empty links and preserve their frame information for downstream users.
Relevant comments from Asana:
@scpeters : links without inertias connected to another link via a fixed joint could clearly be converted to a frame on the parent link, but what if the link without inertia has a collision or visual, or it's connected by a different type of joint?
@EricCousineau-TRI
Sounds like using the welding approach work best, though it does incur the cost of an additional joint.
For visuals / collisions in those links, I guess you could update their //pose/@relative_to, but that sounds a tad hairy.
@azeey
So, currently, by default (you can set a parameter to disable this), the collisions and visuals get lumped into the link that has inertia. We can keep doing that, but in addition, create a frame for the the link without inertia attached to the link with the inertia. This would make it possible for a gazeb-ros plugin to publish static transforms for the link without inertia, which I think is the desired effect.
The text was updated successfully, but these errors were encountered: