Spine support git clone branch in git action

[singlecoder]

Summary by CodeRabbit

• Chores
  • Updated GitHub Actions workflow configuration
  • Modified repository cloning process for engine-spine
  • Added WebAssembly file configuration in build process

[coderabbitai]

Walkthrough

The GitHub Actions workflow file has been updated to modify the cloning process for the engine-spine repository by specifying the dev/4.2 branch. A new configuration has been added to the bundling step, introducing a wasm array in the ADAPTER_BUNDLE_SETTINGS environment variable. This array includes a path to a WebAssembly file (physx.release.wasm) located in the packages/physics-physx/libs directory, enhancing the repository's build and bundling process.

Changes

File	Change Summary
.github/workflows/release.yml	- Updated engine-spine repository cloning to use dev/4.2 branch - Added wasm array to ADAPTER_BUNDLE_SETTINGS with physx.release.wasm path

Possibly related PRs

• feat: update release action #2474: Modifications to .github/workflows/release.yml involving release process and bundling steps

Suggested reviewers

• GuoLei1990

Poem

🐰 A workflow dance, branches anew,
WebAssembly joins the coding crew
From dev/4.2, engines spin
Bundling magic begins to grin
Release workflows hop with delight! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1337ddd and 1ba10ad.

📒 Files selected for processing (1)

• .github/workflows/release.yml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: build (22.x, windows-latest)
• GitHub Check: e2e (22.x)
• GitHub Check: codecov

🔇 Additional comments (2)

.github/workflows/release.yml (2)

49-49: Verify version compatibility with engine-spine dev/4.2 branch.

While specifying the branch explicitly is good for reproducibility, we should ensure that the dev/4.2 branch of engine-spine is compatible with the current engine version.

Let's verify the compatibility by checking the engine version requirements:

✅ Verification successful

Branch specification is compatible and provides better reproducibility ✅

The dev/4.2 branch of engine-spine requires @galacean/engine version >=1.3.20, which is satisfied by the current engine version 1.4.0-alpha.3. The explicit branch specification in the clone command is a good practice for ensuring reproducible builds.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check engine version requirements in engine-spine's dev/4.2 branch
git clone --depth 1 -b dev/4.2 https://github.com/galacean/engine-spine.git temp-spine
cat temp-spine/package.json | jq -r '.peerDependencies["@galacean/engine"]'
rm -rf temp-spine

Length of output: 286

---

Script:

#!/bin/bash
# Check current engine version
cat package.json | jq -r '.version'

Length of output: 49

---

124-126: Unrelated change: WASM configuration addition.

The addition of the WASM configuration for PhysX appears unrelated to the PR's stated objective of "Spine support git clone branch". Consider splitting this change into a separate PR for better traceability and review focus.

Let's check if this WASM file is referenced in other recent changes:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.41%. Comparing base (7fae92c) to head (1ba10ad).
Report is 2 commits behind head on dev/1.4.

Additional details and impacted files

@@             Coverage Diff             @@
##           dev/1.4    #2488      +/-   ##
===========================================
- Coverage    68.91%   68.41%   -0.50%     
===========================================
  Files          923      923              
  Lines        96043    96047       +4     
  Branches      8134     8137       +3     
===========================================
- Hits         66189    65714     -475     
- Misses       29601    30079     +478     
- Partials       253      254       +1     

Flag	Coverage Δ
unittests	68.41% <ø> (-0.50%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.