Add wasm upload in git action #2491
Conversation
WalkthroughThe pull request modifies the GitHub Actions release workflow configuration by adding a "wasm" entry to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
124-126: Consider adding error handling for missing WASM files.The bundling process should handle cases where the WASM file is missing, either by failing gracefully or providing clear error messages.
Consider adding a pre-bundle check step:
- name: Bundle polyfill and engine + - name: Verify WASM files + run: | + for wasm_file in packages/physics-physx/libs/physx.release.wasm; do + if [ ! -f "$wasm_file" ]; then + echo "Error: Required WASM file not found: $wasm_file" + exit 1 + fi + done uses: galacean/platform-adapter@main
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build (22.x, windows-latest)
- GitHub Check: e2e (22.x)
- GitHub Check: codecov
🔇 Additional comments (1)
.github/workflows/release.yml (1)
124-126: Verify the WebAssembly file path and build artifacts.The WASM file path should be verified to ensure it exists and is consistent with the build output structure.
Let's verify the path and related files:
✅ Verification successful
✓ WebAssembly file path and structure verified
The specified path is correct, and all necessary files (WASM and loader) are present in the expected location.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify WASM file path and related build artifacts # Check if the WASM file exists in the specified location fd -t f "physx.release.wasm" packages/physics-physx/libs/ # Check if there are any other WASM files that might need to be included fd -t f ".wasm$" packages/physics-physx/ # Verify the relationship between WASM file and its loader if fd -t f "physx.release.wasm" packages/physics-physx/libs/ >/dev/null; then echo "Checking for corresponding loader file..." fd -t f "physx.release.js" packages/physics-physx/libs/ fiLength of output: 494
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/1.4 #2491 +/- ##
===========================================
+ Coverage 68.42% 68.44% +0.01%
===========================================
Files 923 923
Lines 95904 96059 +155
Branches 8138 8140 +2
===========================================
+ Hits 65621 65744 +123
- Misses 30029 30062 +33
+ Partials 254 253 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit