Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TotK images #47

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Added TotK images #47

merged 1 commit into from
Dec 4, 2024

Conversation

freshefisch
Copy link
Contributor

@freshefisch freshefisch commented Nov 11, 2024

I have added the images for every compendium entry of totk with the following properties, as discussed in #30 (comment) :

  • 280x280 resolution
  • 24 bit
  • File name matches the entry's name (to lowercase and space replaced with underscore), HOWEVER see below
  • Size ca. 80-130 KB each
  • Total size ca. 55 MB

There is one possible issue I could already spot:
The image: value of weapons that end with (new) are missing an underscore right before (should be _(new))!
This seems to be because the same is true for the names of these items. So for example the entry gerudo_scimitar (new) is missing an underscore aswell (should be gerudo_scimitar_(new)).

Edit: It's actually all entries that have more than one space in the name, see my reply below.

https://botw-compendium.herokuapp.com/api/v3/compendium/entry/gerudo_scimitar (new)/image?game=totk

It would be very easy to change the filenames of these couple images, but it's probably best to correct the entries' names. Unless this is on purpose.

See image:
image

@freshefisch freshefisch mentioned this pull request Nov 11, 2024
16 tasks
@freshefisch
Copy link
Contributor Author

Actually the name issue with the underscores in the name seems to be the case for all entries that have more than one space!
For example demon king ganondorf (2nd form)
Image url is: [...]/compendium/entry/demon_king ganondorf (2nd form)/image?game=totk

Here there is actually 3 underscores missing, only the first one was replaced! This probably happened because at some point replace was confused with replaceAll !!!

As of right now this doesn't seem to cause any issues, but with the images it probably will, since the filenames of the images have all spaces replaced with underscores.

@freshefisch
Copy link
Contributor Author

Maybe there's something wrong with these two lines? But .replace in python should replace all occurences. In javascript you'd have to use regex though.

endpoints/db.py (Line 27) and endpoints/db.py (Line 35)

@gadhagod gadhagod self-assigned this Nov 13, 2024
gadhagod added a commit that referenced this pull request Nov 28, 2024
gadhagod added a commit that referenced this pull request Nov 28, 2024
Copy link
Owner

@gadhagod gadhagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @freshefisch! I am eternally grateful for this contribution.

@gadhagod gadhagod merged commit f83f943 into gadhagod:master Dec 4, 2024
1 check failed
@gadhagod
Copy link
Owner

gadhagod commented Dec 4, 2024

Actually the name issue with the underscores in the name seems to be the case for all entries that have more than one space!

I've updated the database and this issue should be fixed now.

Screenshot 2024-12-04 at 3 42 44 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants