-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 Roadmap #30
Comments
Great solution for ingredients, I'm glad you'll be including recipes! edit: I see, 'Towns and Regions' is the heading of the existing issue 🙄. |
Thanks @jeff-stienstra. You brought up a great point. I don't think |
Experimental region endpoints are available at:
|
Very nice!! I get loads of data when testing the API. There are so many shrines in this game! But I'm unsure what would go where Also, not to be picky, but is 'region' the correct terminology considering 'Eldin' is itself a region? I didn't see any specific terms used when researching other than these sub-regions being called 'areas'. ie Eldin Canyon is a large area within the Eldin region. 🤷♂️ Looks like Eldin has these main sub-regions/areas: Great update! |
Thanks for your feedback @jeff-stienstra.
I do plan on adding more information about regions. As of now only shrines, DLC shrines, and settlements are given, but I will add some sub-regions and important areas in the future. Thanks for your suggestion!
|
Just want to show my appreciation for such an awesome project! I've started my own project based on this, and I hope to include an ability for users to login and save recipes, and keep track of what ingredients you have/need for recipes. Right now it's just showing cards for the ingredients, but I'm looking forward to the recipes being a part of it! Here's a link if you want to look --> I'm relative newbie to development, but I'd be happy to help in any way I can! Cheers and thanks again for your hard work on such a useful API. |
Hi @YanceMcFinn. Thanks for your appreciation! Your project is very cool, and I'm excited to see the new features. Seeing people building projects with this API is what makes the development worth it. After the release of TOTK features, development on the Hyrule Compendium API has slowed down, as I have not had enough time to add new features. Because of this, I'm not sure when recipes will be ready. If you are willing to contribute to this effort, please let me know; it would greatly help. |
Great job on the recipe cards page! That's a fun project and a great way to practice front end design and API usage as a newer developer. Maybe you could create a landing page that will link to the different API resources gadhagod has available (recipes, regions, shrines, etc)? Keep it up! |
Hi, I'm really enjoying playing around with the API as someone who is learning web programming att he moment. I was wondering if there's anything that can be done to assist with progress you're looking to make on the roadmap. The one piece I'm specifically interested in having access to in the API is ToTK images but I'd be happy to lend a hand in any area. Thanks! |
Hey not sure if this is still being updated or needs some work. I've been playing around with it to make a tracker, willing to assist with getting TOTK images up if still an option! |
Hey, I saw that the images for totk haven't been added yet If you want to use them, I got all the images of totk here: If you want to connect the image filenames to the entries, check out this file: @yanader @XavierLora Maybe one of you wants to go through the work of mapping the images to the IDs that this api uses? Should be relatively straight forward, just handle the cases where a match can't be found manually I'd say. I might just do it myself if no one else does. |
Okay I just went ahead and did such a mapping. Every entry matches an image filename. To compare it to the entries of the api, all you have to do is replace each space Now all that's left to do is make the images
I'm not sure what changes to the code are necessary otherwise. |
Thank you @BustyBee and @freshefisch for your help! It is deeply appreciated. As for your questions on #46 (comment) on self-hosting, the current guide is out of date since migrating to MongoDB. I'm currently working on a new self-hosting guide but the process is a bit complicated so it's taking time. I would greatly appreciate your contribution to this project. Fortunately, adding images is pretty much a no-code change and won't require you to run the server on your own to add them. Would you be able to make the changes you mentioned in your comment, specifically adjusting the image sizes? If you are able to make them 280x280 and add them to the If you are down to contribute, the image names should be lowercase and spaces replaced by underscores. Take a look here to see how I named the PNGs for BOTW. Thank you for using this API! Have a great day. |
I will get to it as soon as I can! Just a heads up, I've never done a PR before so I apologize if I do something wrong. But I watched a couple tutorials so should be fine. I'll also make sure to write a python script that checks if there is an image for every compendium entry, to make sure I have all the images and the names are correct. If you want to I can also share this script. |
I have created a pull request regarding the totk images (files only) #47 Edit: Please see the issue I have described before pulling in #47 (comment) |
Thanks to @freshefisch, TOTK images are now up! Here's an example. TODO: add docs for TOTK images |
The new version of the Hyrule Compendium API will serve data on more than just the compendium entries. It will contain the following categories of data:
/compendium
)/regions
) (Towns and Regions? #29)/recipes
) (Recipe list #27)The goal is to make this API more than just the compendium; it should be able to give data on all (or many) aspects of the game, not just the in-game items.
Recipes
Recipes will be divided based on their base ingredient (e.g seafood). Multi-dimensional arrays will be used to represent possible ingredients to tackle the problem of substitutable ingredients.
Possible example recipe response:
Map
Data on each region, including encompassed shrines and settlements, will be provided.
Compendium
dlc
that specifies if it is a master-mode exclusive. The/master_mode
endpoint will remain to avoid ID conflicts.food
andnon_food
keys in the creatures category response will be removed. Each creature entry will have a boolean propertyedible
instead./all
(endpoint to get all entries) will not have keys for each category.attack
anddefense
keys of items of theequipment
category will be nested in theproperties
key like so:?game=totk
or?game=2
) (Do you plan on updating this API for Tears of the Kingdom #36)Code Changes
These changes will not affect the usage of the API. It will improve performance and clean up code.
Flask().add_url_rule
UNION
is a better solutionAdditional Tasks
Feel free to chime in on this thread.
The text was updated successfully, but these errors were encountered: