Bugfix: fix deform augment edge cases

[cmalinmayor]

• Use the full ROI and not just the spatial roi for cropping graph
• Allow the jitter to be float valued and not a Coordinate
• Use the control point spacing already cast to Coordinate to determine the raster voxel size default value
• Avoid an empty zip in the fast points projection

Pre-Merge Checklist:

• if this PR fixes a bug: request merge into the latest patch branch (patch-X.Y.Z)
• PR branch name is short and describes the feature/bug addressed in this PR
• commit messages are consistent
• changes reviewed by another contributor
• tests cover changes
• all tests pass

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (patch-1.4.1@0b3d03c). Learn more about missing BASE report.

Additional details and impacted files

@@              Coverage Diff               @@
##             patch-1.4.1     #223   +/-   ##
==============================================
  Coverage               ?   68.66%           
==============================================
  Files                  ?      100           
  Lines                  ?     6925           
  Branches               ?        0           
==============================================
  Hits                   ?     4755           
  Misses                 ?     2170           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pattonw]

Everything looks good to me. Just some nit picky comments

If you have time It would be nice to add or adjust a test case so that tests fail without this bugfix but pass with it

[cmalinmayor]

Everything looks good to me. Just some nit picky comments

Wait I don't see the comments - I don't think you officially submitted a "review" so maybe that's why (it still says review pending)

[cmalinmayor]

If you have time It would be nice to add or adjust a test case so that tests fail without this bugfix but pass with it

@pattonw I adapted my downstream test case that I was using to actually find the bugs and added it to the deform augment tests. We now have two pretty different kinds of tests - I can unify if you want, but I'm not sure what the best way to test actually is. Using GPGraphSource seems simpler to set up the test source, but I'm not sure if there are downsides?

[pattonw]

Yes, your test is significantly better since it doesn't create a custom node, is much more succinct. I have been slowly removing custom nodes in favor of simple Array and Graph source nodes for legibility and maintainability. If you would do that here that would be greatly appreciated, but is not necessary. I'm happy enough just having the coverage extension to 4D data