Skip to content

fix(ci): green main — Resend endpoint verb + password toggle a11y label #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iammukeshm merged 1 commit into from
Jun 4, 2026
+5 −2
Merged

fix(ci): green main — Resend endpoint verb + password toggle a11y label #1280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/dashboard/src/pages/settings/security.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ function PasswordField({
<button
type="button"
tabIndex={-1}
aria-label={show ? `Hide ${label.toLowerCase()}` : `Show ${label.toLowerCase()}`}
aria-label={show ? "Hide password" : "Show password"}
onClick={() => setShow((s) => !s)}
className="absolute right-1.5 top-1/2 grid size-6 -translate-y-1/2 place-items-center rounded-md text-[var(--color-muted-foreground)] outline-none transition-colors hover:text-[var(--color-foreground)] focus-visible:ring-2 focus-visible:ring-[oklch(from_var(--color-ring)_l_c_h_/_0.5)]"
>
Expand Down
4 changes: 3 additions & 1 deletion clients/dashboard/tests/settings/security.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ test.describe("settings/security — change password (Dialog)", () => {
await dialog.getByLabel("New password", { exact: true }).fill("longenough123");
await dialog.getByLabel("Confirm new password").fill("differentpw123");
await dialog.getByRole("button", { name: /update password/i }).click();
await expect(dialog.getByText(/passwords don't match/i)).toBeVisible();
// Scope to the submit-error alert — the live "…don't match yet" hint under
// the confirm field also contains this phrase.
await expect(dialog.getByRole("alert")).toContainText(/passwords don't match/i);

// Current === new is blocked — keeps users from "rotating" to the
// same value just to reset a forgotten password.
Expand Down
1 change: 1 addition & 0 deletions src/Tests/Architecture.Tests/EndpointConventionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ public void Endpoint_Names_Should_Follow_Convention()
name.StartsWith("Register", StringComparison.Ordinal) ||
name.StartsWith("Generate", StringComparison.Ordinal) ||
name.StartsWith("Refresh", StringComparison.Ordinal) ||
name.StartsWith("Resend", StringComparison.Ordinal) ||
name.StartsWith("Confirm", StringComparison.Ordinal) ||
name.StartsWith("Reset", StringComparison.Ordinal) ||
name.StartsWith("Forgot", StringComparison.Ordinal) ||
Expand Down
Loading