fix(ci): green main — Resend endpoint verb + password toggle a11y label#1280
Merged
Merged
Conversation
Three failing workflows on main (2df3c26) traced to two source issues: - Architecture.Tests EndpointConventionTests rejected the new ResendConfirmationEmailEndpoint ("Resend" was not an allowed action verb). Broke Backend CI Unit Tests and Template Smoke Test. - dashboard settings/security PasswordField toggle used a field-specific aria-label ("Show current password") that collided with the inputs under Playwright getByLabel strict mode. Aligned to the repo-wide generic "Show password"/"Hide password" used in login/reset-password. Broke Frontend CI E2E (dashboard). Also tightened the unmasked "passwords don't match" assertion to the role=alert region (the live "...don't match yet" hint shares the phrase). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
Why
main(2df3c264, merge of #1279) went red across three workflows: Backend CI (Unit Tests), Frontend CI (E2E dashboard), and Template Smoke Test. All trace to two source issues introduced by that merge.Fixes
ResendConfirmationEmailEndpointfailedEndpointConventionTests.Endpoint_Names_Should_Follow_ConventionbecauseResendwas not in the allowed action-verb list. Added it. (fixes Backend CI Unit Tests + Template Smoke, which runs the same arch test on scaffolded output.)settings/securityPasswordFieldtoggle used a field-specificaria-label("Show current password") that collided with the password inputs under PlaywrightgetByLabelstrict mode. Aligned to the repo-wide generic"Show password"/"Hide password"already used inlogin.tsxandreset-password.tsx. (fixes Frontend CI E2E dashboard — 6 strict-mode violations.)getByText(/passwords don't match/i)matched both the live "…don't match yet" hint and the submit error. Scoped the assertion to therole="alert"region.Verification
Architecture.TestsEndpoint_Names_Should_Follow_Convention→ Passedclients/dashboardtests/settings/security.spec.ts→ 10/10 passed🤖 Generated with Claude Code
@