Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project maintenance updates #2763

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Project maintenance updates #2763

wants to merge 8 commits into from

Conversation

xperiandri
Copy link
Collaborator

@xperiandri xperiandri commented Oct 1, 2023

Description

  • Migrate to default .gitignore
  • Updated Paket to 7.2.1
  • Update Fantomas to 6.3.10
  • Update FsDocs to 19.1.0
  • Update .NET SDK on CI to 6.0.424
  • Make .editorconfig more safe
  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
  • Fake API guideline is honored

@Numpsy
Copy link
Contributor

Numpsy commented Oct 1, 2023

/home/runner/work/FAKE/FAKE> "dotnet"  fantomas src/app/ src/template/ src/test/ --recurse --check (In: false, Out: false, Err: false)
Unhandled exception. System.IO.DirectoryNotFoundException: Could not find a part of the path '/home/runner/work/FAKE/FAKE/--recurse'.

I think Fantomas 6 made the folder searching recursive by default, and deprecated the command line flag for it - so ---recurse can be removed from the invocation?

@xperiandri xperiandri force-pushed the project-maintenance branch 2 times, most recently from f40c601 to 047a1a1 Compare October 29, 2023 18:44
@Numpsy
Copy link
Contributor

Numpsy commented Nov 24, 2023

Is it worth updating Paket to v8 now, or leave that till later?

@xperiandri
Copy link
Collaborator Author

I would release this changes to v6 and then updated to v8

@Thorium
Copy link
Member

Thorium commented Jul 15, 2024

The build failure of this comes because Paket v7 cannot handle component having dependencies of .net8. This is already fixed in master by Paket update to v8, but this commit has explicit Paket v7 change.

Thus I think best way could be git cherry-pick 112461702ff11682a90a2c15129700e5c831fc5f (.gitignore) and
git cherry-pick 51566248dd972b5699c8bd08cb1163bad9317be1 (.editorconfig) and well, the Fantomas update is not very high priority.

I'd first merge other PRs and release new version(s) (how is this released? To NuGet/dotnet-tools/...?) and then when all is good, then re-consider the Fantomas update.

@xperiandri xperiandri force-pushed the project-maintenance branch 7 times, most recently from 1d325ab to ef81324 Compare July 31, 2024 12:29
@NogginBops NogginBops mentioned this pull request Aug 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants