Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try running the macOS CI builds on macOS 13 #2773

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Feb 15, 2024

Just seeing if it has any effect on the intermittent macOS CI issues really - as per the github docs at https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources 'macOS-latest' actually uses macOS 12, and the macOS 13 runner also has more CPU cores than the 12 runner

@Numpsy
Copy link
Contributor Author

Numpsy commented Apr 3, 2024

I see that the macos-latest runners are now using macOS 14 / ARM cpus, so not sure if this is helpful any more or not

@Thorium
Copy link
Member

Thorium commented May 26, 2024

The current Mac-CI seems to fail...

@Numpsy
Copy link
Contributor Author

Numpsy commented May 26, 2024

The errors in the latest builds sound like dotnet/runtime#64103 ?
That does say it effects ARM cpus though, so I guess the builds having jumped to macOS 14 / ARM runners would be the cause of that,

@Numpsy
Copy link
Contributor Author

Numpsy commented May 27, 2024

The changes in #2763 including updating the .NET 6.0 SDK in the CI builds to 6.0.414 which acording to the issue I linked fixes the problem on ARM macs, but that has been WIP for a while.
It does look like it either needs to have the SDK updated, or be changed to use the Intel macOS runners though.

@Numpsy Numpsy mentioned this pull request Jun 4, 2024
@Numpsy
Copy link
Contributor Author

Numpsy commented Jun 17, 2024

As it stands, this is the only change that seems to have got the macOS build to pass :-(

@Thorium
Copy link
Member

Thorium commented Jun 28, 2024

Can we get this merged? "Review required", who is the maintainer here?

I think this project would have other useful PRs to merge too. Before those are merged, it's quite pointless to compile projects using FAKE (many F# projects) with .NET 8.0, better just keep Global.json to point at .NET6. Which is good and .NET8 compatible, but sometimes .NET 8 could give some more performance and new features.

@Numpsy
Copy link
Contributor Author

Numpsy commented Jun 28, 2024

@xperiandri any thoughts?

@Thorium
Copy link
Member

Thorium commented Jun 28, 2024

There are 10+ PRs in line (which most fail CI because of this issue here), and not many commits in recent 6 months. FAKE is still lot used project, and if the maintainers feel here that FAKE is not anymore their interest, could they reach e.g. Amplifying F# to get more resources allocated here?

@xperiandri xperiandri enabled auto-merge (rebase) July 11, 2024 13:44
@xperiandri xperiandri merged commit 6665c18 into fsprojects:master Jul 11, 2024
3 checks passed
@Numpsy Numpsy deleted the os13 branch July 11, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants