Many updates #18
Merged
Many updates #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pbrisbin
commented
Jan 10, 2025
pbrisbin
commented
- git-ignore stack.yaml.lock files
- Rename stack-lts files to only specify major
- Use new haskell-actions organization
- Configure actions-based Restyled
- Add .stack-all configuration
- Add stack configurations for lts 21 through 23
- Make stack.yaml a symlink to stack-lts23.yaml
- Update release workflow
These lock files help with reproducibility and can alert developers if the exact code behind a given resolver or extra-dep has changed since the last build. However, certain tooling does or does not keep them updated and this fact has led to confusion that is not worth this benefit, particularly in projects with a lot of separate resolver files. Therefore, we're going to start phasing out keeping them committed.
That's all that matters, and we don't want filenames (and test matrix names) to change if minor versions fluctuate. As part of this we move, to a hyphen-less suffix since that's what some tooling (stack-all) expects, and it doesn't negatively affect anything else.
- `haskell-tag-action` doesn't need an explicit token - `stack-upload-action` is deprecated, just use `stack upload`
Newer hspec-discover seems to include an export list.
Anecdotally, `app,src,test` is more common that `executables,library,tests`. It's also what `stack new` creates (`cabal init` creates no directories). No one on the team expressed a strong objection[^1], so we'll start a soft migration (i.e. use it in new stuff, change at our leisure). [^1]: https://freckleinc.slack.com/archives/C459XJBGR/p1702402421106759
This reverts commit e05e6fe.
chris-martin
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.