Many updates

* git-ignore stack.yaml.lock files

These lock files help with reproducibility and can alert developers if
the exact code behind a given resolver or extra-dep has changed since
the last build. However, certain tooling does or does not keep them
updated and this fact has led to confusion that is not worth this
benefit, particularly in projects with a lot of separate resolver files.
Therefore, we're going to start phasing out keeping them committed.

* Rename stack-lts files to only specify major

That's all that matters, and we don't want filenames (and test matrix
names) to change if minor versions fluctuate.

As part of this we move, to a hyphen-less suffix since that's what some
tooling (stack-all) expects, and it doesn't negatively affect anything
else.

* Use new haskell-actions organization

* Configure actions-based Restyled

* Add .stack-all configuration

* Add stack configurations for lts 21 through 23

* Make stack.yaml a symlink to stack-lts23.yaml

* Update release workflow

- `haskell-tag-action` doesn't need an explicit token
- `stack-upload-action` is deprecated, just use `stack upload`

* Add typically-disabled 9.8 warnings

* Add lts20-like extra-deps to lts21

* Update extra-deps in lts21

* Remove unnecessary pragma

Newer hspec-discover seems to include an export list.

* Move from library,tests to src,test

Anecdotally, `app,src,test` is more common that
`executables,library,tests`. It's also what `stack new` creates (`cabal
init` creates no directories). No one on the team expressed a strong
objection[^1], so we'll start a soft migration (i.e. use it in new
stuff, change at our leisure).

[^1]: https://freckleinc.slack.com/archives/C459XJBGR/p1702402421106759

.github/workflows/ci.yml

@@ -39,7 +39,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: haskell/actions/hlint-setup@v2
-      - uses: haskell/actions/hlint-run@v2
+      - uses: haskell-actions/hlint-setup@v2
+      - uses: haskell-actions/hlint-run@v2
         with:
           fail-on: warning

.github/workflows/release.yml

@@ -13,10 +13,9 @@ jobs:
 
       - id: tag
         uses: freckle/haskell-tag-action@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - if: steps.tag.outputs.tag
-        uses: freckle/stack-upload-action@v2
+        run: stack upload --pvp-bounds lower .
         env:
-          HACKAGE_API_KEY: ${{ secrets.HACKAGE_UPLOAD_API_KEY }}
+          HACKAGE_KEY: ${{ secrets.HACKAGE_UPLOAD_API_KEY }}
+          STACK_YAML: stack-lts12.yaml

.github/workflows/restyled.yml

@@ -0,0 +1,18 @@
+name: Restyled
+
+on:
+  pull_request:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  restyled:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: restyled-io/actions/setup@v4
+      - uses: restyled-io/actions/run@v4
+        with:
+          suggestions: true

.gitignore

@@ -1,3 +1,4 @@
-.stack-work
 *.hie
 .hiedb
+.stack-work
+stack*.yaml.lock

.stack-all

@@ -0,0 +1,2 @@
+[versions]
+oldest = lts-12

haskell-library-template.cabal

@@ -1,6 +1,6 @@
 cabal-version: 1.18
 
--- This file has been generated from package.yaml by hpack version 0.36.0.
+-- This file has been generated from package.yaml by hpack version 0.37.0.
 --
 -- see: https://github.com/sol/hpack
 
@@ -33,7 +33,7 @@ library
   other-modules:
       Paths_haskell_library_template
   hs-source-dirs:
-      library
+      src
   default-extensions:
       BangPatterns
       DataKinds
@@ -63,6 +63,8 @@ library
   build-depends:
       base <5
   default-language: Haskell2010
+  if impl(ghc >= 9.8)
+    ghc-options: -Wno-missing-role-annotations -Wno-missing-poly-kind-signatures
   if impl(ghc >= 9.2)
     ghc-options: -Wno-missing-kind-signatures
   if impl(ghc >= 8.10)
@@ -105,6 +107,8 @@ test-suite readme
       base <5
     , markdown-unlit
   default-language: Haskell2010
+  if impl(ghc >= 9.8)
+    ghc-options: -Wno-missing-role-annotations -Wno-missing-poly-kind-signatures
   if impl(ghc >= 9.2)
     ghc-options: -Wno-missing-kind-signatures
   if impl(ghc >= 8.10)
@@ -120,7 +124,7 @@ test-suite spec
       WhateverSpec
       Paths_haskell_library_template
   hs-source-dirs:
-      tests
+      test
   default-extensions:
       BangPatterns
       DataKinds
@@ -152,6 +156,8 @@ test-suite spec
     , hspec
     , hspec-junit-formatter
   default-language: Haskell2010
+  if impl(ghc >= 9.8)
+    ghc-options: -Wno-missing-role-annotations -Wno-missing-poly-kind-signatures
   if impl(ghc >= 9.2)
     ghc-options: -Wno-missing-kind-signatures
   if impl(ghc >= 8.10)

package.yaml

@@ -30,6 +30,10 @@ ghc-options:
   - -Wno-unsafe
 
 when:
+  - condition: "impl(ghc >= 9.8)"
+    ghc-options:
+      - -Wno-missing-role-annotations
+      - -Wno-missing-poly-kind-signatures
   - condition: "impl(ghc >= 9.2)"
     ghc-options:
       - -Wno-missing-kind-signatures
@@ -71,12 +75,12 @@ default-extensions:
   - TypeFamilies
 
 library:
-  source-dirs: library
+  source-dirs: src
 
 tests:
   spec:
     main: Spec.hs
-    source-dirs: tests
+    source-dirs: test
     ghc-options: -threaded -rtsopts "-with-rtsopts=-N"
     dependencies:
       #- haskell-library-template