Skip to content

Conversation

@cogk
Copy link

@cogk cogk commented May 5, 2025

@RitvikSardana
Copy link
Member

Please solve merge conflicts @cogk

@cogk cogk force-pushed the feat-disable-search-on-customer-portal branch from 3402785 to a770aaa Compare May 29, 2025 15:10
@cogk
Copy link
Author

cogk commented May 29, 2025

Done! @RitvikSardana ☺️

@RitvikSardana
Copy link
Member

I think it should be "enable article search"

In description you can write, that "relevant articles will be shown on the ticket page while typing the subject" or something like that

default value will be 1

@cogk

What do you think?

@cogk cogk force-pushed the feat-disable-search-on-customer-portal branch from a770aaa to 762b978 Compare May 29, 2025 15:32
@RitvikSardana
Copy link
Member

RitvikSardana commented May 29, 2025

image

default value did not come 😕

this will break functionality of many sites

@cogk
Copy link
Author

cogk commented May 29, 2025

Hmm I agree, I guess default values in Single Documents do NOT work 😥

@cogk
Copy link
Author

cogk commented May 29, 2025

I suppose I should swap it again to the negative version "hide_suggested_articles" 😆

@RitvikSardana
Copy link
Member

RitvikSardana commented May 29, 2025

Thing is, it works for new sites the default value, but does not for existing one, so I wrote a patch to fix it

@cogk
Copy link
Author

cogk commented May 29, 2025

Oh nice, perfect! 👍

@RitvikSardana
Copy link
Member

Can you share a screenshot of search articles being shown when this flag is enabled?

I cant seem to get search results

@cogk
Copy link
Author

cogk commented May 29, 2025

Just to be sure: are you on the customer portal?

image


The same screenshot with the feature disabled:

image

@RitvikSardana
Copy link
Member

No I meant with some search results, like some options of search

@cogk
Copy link
Author

cogk commented Jun 1, 2025

No I meant with some search results

Oh I understand, this feature I never tried to make it work so I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants