Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add block_explorer field to ShowConfigResponse #2750

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+43 −1
Open

feat: Add block_explorer field to ShowConfigResponse #2750

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c3fa02
feat: Add block_explorer field to ShowConfigResponse
mexes20 Dec 4, 2024
509b0c8
Merge branch 'master' into block_explorer
mexes20 Dec 7, 2024
1a4f30a
test to cover both default and non-default block-explorer cases
mexes20 Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/sncast/src/helpers/configuration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ pub struct CastConfig {
pub wait_params: ValidatedWaitParams,

#[serde(
default,
default = "default_block_explorer",
rename(serialize = "block-explorer", deserialize = "block-explorer")
)]
/// A block explorer service, used to display links to transaction details
Expand All @@ -48,6 +48,11 @@ pub struct CastConfig {
pub show_explorer_links: bool,
}

/// Default block explorer function
mexes20 marked this conversation as resolved.
Show resolved Hide resolved
fn default_block_explorer() -> Option<block_explorer::Service> {
Some(block_explorer::Service::default())
}

impl Default for CastConfig {
fn default() -> Self {
Self {
Expand Down