feat: Add block_explorer field to ShowConfigResponse #2750
+43
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mexes20
requested review from
cptartur,
ddoktorski,
kkawula and
franciszekjob
as code owners
ddoktorski
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Thank you for your contribution @mexes20
Please extend the existing show-config tests to cover both default and non-default block-explorer cases.
ddoktorski
requested changes
Dec 9, 2024
| @@ -128,3 +128,40 @@ async fn test_show_config_no_url() { | |||
| wait_timeout: 500 | |||
| "}); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_show_config_default_block_explorer() { | |||
There was a problem hiding this comment.
This check can be added in the test_show_config_from_snfoundry_toml instead of creating a separate test
| chain_id: alpha-sepolia | ||
| profile: profile5 | ||
| rpc_url: {} | ||
| block_explorer: blockscout |
There was a problem hiding this comment.
This blok explorer is not supported, please add the custom check for Voyager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2711
Introduced changes
Checklist
CHANGELOG.md