Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODSOURCE-796 Cleanup permissions #646

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

MODSOURCE-796 Cleanup permissions #646

wants to merge 16 commits into from

Conversation

dmytrokrutii
Copy link
Contributor

@dmytrokrutii dmytrokrutii commented Sep 18, 2024

Purpose

Permission refactoring

TODOs

For each renamed permissions: Search for all **/ModuleDescriptor* and all package.json of other modules that contain them and ensure that a pull request exists that changes the name.

Learning:

MODSOURCE-796
Naming convention

Progress table for renaming permissions for Folijet team modules:
https://docs.google.com/spreadsheets/d/1PFnPx-nrslchWuYFvcB95wyIBdMwUdUcTnpErPc3uG4/edit?usp=sharing

@dmytrokrutii dmytrokrutii self-assigned this Sep 18, 2024
@dmytrokrutii dmytrokrutii marked this pull request as draft October 2, 2024 09:52
@dmytrokrutii dmytrokrutii marked this pull request as ready for review October 7, 2024 10:44
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure to update the module descriptor/package.json of all modules that call a mod-source-record-storage API protected by a renamed permission.
I've started a TODOs list in this PR's description.

Copy link

sonarcloud bot commented Oct 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants