-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODCPCT-87 API versions update #112
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use "replaces" so that this is not a breaking change.
New permissions in mod-source-record-storage and mod-source-record-manager already have the "replaces" keyword. Taras Spashchenko:
You also can see this folio-org/mod-data-import#337 (comment) |
Only the owning module can use "replaces". mod-copycat is not the owner of the changes permissions. The owners already have "replaces" for them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@MikeTaylor Please review you approval rejection. |
Quality Gate passedIssues Measures |
MODCPCT-87
According to the epic https://folio-org.atlassian.net/browse/FOLIO-4044, some permissions have been changed in the source-manager-job-executions v3.4 and source-storage-source-records v3.5
mod-copycat uses the following outdated permissions:
Merge this pull request at the same time when the other modules merge the permission rename pull requests: