Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODCPCT-87 API versions update #112

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

MODCPCT-87 API versions update #112

wants to merge 5 commits into from

Conversation

dmytrokrutii
Copy link

@dmytrokrutii dmytrokrutii commented Sep 25, 2024

MODCPCT-87

According to the epic https://folio-org.atlassian.net/browse/FOLIO-4044, some permissions have been changed in the source-manager-job-executions v3.4 and source-storage-source-records v3.5

mod-copycat uses the following outdated permissions:

"change-manager.jobexecutions.put"
"source-storage.sourceRecords.get" 
New permission API
"change-manager.jobExecutions.jobProfile.item.put" /change-manager/jobExecutions/{id}/jobProfile
"source-storage.source-records.collection.get" "/source-storage/source-records"

Merge this pull request at the same time when the other modules merge the permission rename pull requests:

@dmytrokrutii dmytrokrutii marked this pull request as draft September 25, 2024 10:56
@dmytrokrutii dmytrokrutii self-assigned this Sep 25, 2024
Copy link
Contributor

@MikeTaylor MikeTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use "replaces" so that this is not a breaking change.

@dmytrokrutii
Copy link
Author

dmytrokrutii commented Oct 3, 2024

Please use "replaces" so that this is not a breaking change.

New permissions in mod-source-record-storage and mod-source-record-manager already have the "replaces" keyword.
However, this does not negate the need to change the names in all the affected modules.

Taras Spashchenko:

And yes, if you change the permission name, you must change all references to the old name throughout the FOLIO in all repositories.

You also can see this folio-org/mod-data-import#337 (comment)

@MikeTaylor

@julianladisch
Copy link
Contributor

Please use "replaces" so that this is not a breaking change.

Only the owning module can use "replaces". mod-copycat is not the owner of the changes permissions. The owners already have "replaces" for them.

@dmytrokrutii dmytrokrutii changed the title MODCPCT-87 Rename module permissions MODCPCT-87 API versions update Oct 7, 2024
@dmytrokrutii dmytrokrutii marked this pull request as ready for review October 7, 2024 13:23
Copy link
Contributor

@julianladisch julianladisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@julianladisch
Copy link
Contributor

@MikeTaylor Please review you approval rejection.

NEWS.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants