Fix french holidays #328
Merged
Fix french holidays #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: XSpielinbox <[email protected]>
Merged
|
I also could not find anything that Easter is a valid public holiday or holiday in France. See https://en.wikipedia.org/wiki/Public_holidays_in_France I think we should drop it. |
|
See https://www.legifrance.gouv.fr/codes/article_lc/LEGIARTI000033020901
Ok, then I would leave the commit as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎁 enable
assertAllHolidaysCheckedfor France🐞 This also aligns the
descriptionPropertiesKeysofHolidays_test_fr_2010.xmlwith the definitions inholiday_description.propertiesThereby the following issue was found and fixed:
🐞 Easter Sunday is not a public holiday in France
closes #331