Cleanup tests #327
Merged
Cleanup tests #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: XSpielinbox <[email protected]>
Signed-off-by: XSpielinbox <[email protected]>
derTobsch
reviewed
Sep 26, 2023
derTobsch
reviewed
Sep 26, 2023
XSpielinbox
force-pushed
the
cleanup_tests
branch
from
d16714e
to
e33ba51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐞 align the
descriptionPropertiesKeyof New year's day of the London metal exchange with theholiday_description.properties- before it would have had a description ofundefined🎁 remove duplicate code in
testManagerSameInstanceandtestManagerDifferentInstancemethods in tests to avoid errors and make it more clear and easier to read as well as unify naming🐞 fix naming of various testcases
🎁 replace multiple testcases that test individual years with
ParamatrizedTest, to avoid code duplication.🐞 This also fixes an error in the Ukraine tests where the test for 2014 (probably by accident) tested against the year 2018, wherefore an issue in the test-data for 2014 remained unnoticed. I checked with the official laws on the government website online, that indeed holidays get moved, to the next Monday, if they fall on a weekend and the 24.08.2014, was a Sunday.
🎁 enable
assertAllHolidaysCheckedfor more years/countries.🐞 This also aligns the
descriptionPropertiesKeys of various countries' test-data with the definitions inholiday_description.propertiescloses #330