WIP F-Droid market #698

btry · 2018-08-21T12:02:33Z

rebase of #193

provides a way to get apps from fdroid, download them as new packages and update them automatically.

Changes description

Checklist

Please check if your PR fulfills the following specifications:

Tests for the changes have been added
Docs have been added/updated

Estimated time

Assignee	🍅
@btry	2630
@ajsb85	1
@DIOHz0r	19

References

Closes #N/A
Related #N/A
Depends on #N/A

DIOHz0r

CI is failing and you didn't complete pomodoro info

btry · 2018-08-21T13:26:23Z

@DIOHz0r
this feature started in october 2017... sorry I don't remember with good accuracy the time needed to do this feature.

ghost · 2018-08-22T14:00:44Z

There were the following issues with this Pull Request

Commit: 575a7d2
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

accesslint

There are accessibility issues in these changes.

accesslint · 2018-08-22T14:00:45Z

tests/suite-unit/PluginFlyvemdmPackage.php

+      $png = 'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNkYPhfDwAChwGA60e6kgAAAABJRU5ErkJggg==';
+
+      $instance = $this->newTestedInstance();
+      $output = $instance::getSpecificValueToDisplay('icon', ['icon' => $png]);


You're missing an alt attribute here. This is a problem for people using screen readers. Here are some tips for what to write.

ghost · 2018-08-22T14:02:45Z

There were the following issues with this Pull Request

Commit: f26134b
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

btry · 2018-08-22T14:08:26Z

I solved all merge conflicts which will occur with release/2.0.0, except one. We must wait the merge of the release branch, then rebase this one, solve the conflict, then merge into develop.

Checking the build remains greek for now.

ghost · 2018-08-22T14:32:54Z

There were the following issues with this Pull Request

Commit: bb33099
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost · 2018-08-23T09:41:34Z

There were the following issues with this Pull Request

Commit: 771d03e
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost · 2018-08-24T16:05:22Z

There were the following issues with this Pull Request

Commit: f306c37
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

Signed-off-by: Thierry Bugier <[email protected]>

Signed-off-by: Domingo Oropeza <[email protected]>

DIOHz0r · 2018-09-25T22:07:19Z

Hello, I did a rebase here for fixing the conflicts.

btry · 2018-09-26T06:15:20Z

I still need to validate that updates of apps in fdroid propagate automatically to devices when needed

…nto feature/fdroid_2

btry self-assigned this Aug 21, 2018

DIOHz0r added this to the 2.1 milestone Aug 21, 2018

DIOHz0r reviewed Aug 21, 2018

View reviewed changes

btry force-pushed the feature/fdroid_2 branch from a3d07c2 to 168b6ea Compare August 22, 2018 08:27

btry requested review from DIOHz0r and ajsb85 August 22, 2018 13:21

btry force-pushed the feature/fdroid_2 branch 3 times, most recently from 178121a to 7e44ddc Compare August 22, 2018 13:37

ajsb85 previously approved these changes Aug 22, 2018

View reviewed changes

btry dismissed ajsb85’s stale review via 575a7d2 August 22, 2018 14:00

btry force-pushed the feature/fdroid_2 branch from 7e44ddc to 575a7d2 Compare August 22, 2018 14:00

accesslint bot suggested changes Aug 22, 2018

View reviewed changes

btry force-pushed the feature/fdroid_2 branch from 575a7d2 to f26134b Compare August 22, 2018 14:02

btry changed the title ~~Fdroid market~~ WIP Fdroid market Aug 22, 2018

btry mentioned this pull request Aug 22, 2018

Import packages from F-Droid #193

Closed

btry force-pushed the feature/fdroid_2 branch from f26134b to bb33099 Compare August 22, 2018 14:32

btry force-pushed the feature/fdroid_2 branch from bb33099 to 771d03e Compare August 23, 2018 09:41

ajsb85 added the feature label Aug 23, 2018

btry force-pushed the feature/fdroid_2 branch from 771d03e to f306c37 Compare August 24, 2018 16:05

btry force-pushed the feature/fdroid_2 branch 2 times, most recently from e01ee68 to 794e277 Compare September 4, 2018 20:24

ajsb85 previously approved these changes Sep 5, 2018

View reviewed changes

btry and others added 9 commits September 25, 2018 18:01

test: add tests

e233bf1

Signed-off-by: Thierry Bugier <[email protected]>

fix: search options update

f468eea

Signed-off-by: Thierry Bugier <[email protected]>

fix(fdroidmarket): ignore update of markets wihout any URL

0492d7c

Signed-off-by: Thierry Bugier <[email protected]>

test(fdroidmarket): give debug info if test fails

dd4cc9a

Signed-off-by: Thierry Bugier <[email protected]>

test(fdroidmarket): fix deletion of apps on update

886c9a0

Signed-off-by: Thierry Bugier <[email protected]>

build(composer): add SimpleXML extension as required vendors

6682ed0

Signed-off-by: Domingo Oropeza <[email protected]>

docs(tests): add missing tags for tests

e20cb6e

Signed-off-by: Domingo Oropeza <[email protected]>

test(fdroid): add asserts for returned value on repository update

983a211

Signed-off-by: Domingo Oropeza <[email protected]>

test(fdroid): fix test for market on Windows

4cf0db4

Signed-off-by: Domingo Oropeza <[email protected]>

DIOHz0r dismissed their stale review via 4cf0db4 September 25, 2018 22:05

DIOHz0r force-pushed the feature/fdroid_2 branch from c724440 to 4cf0db4 Compare September 25, 2018 22:05

DIOHz0r previously approved these changes Sep 25, 2018

View reviewed changes

Merge branch 'feature/fdroid_2' of github.com-btry:btry/glpi-plugin i…

2b5f9a7

…nto feature/fdroid_2

btry dismissed DIOHz0r’s stale review via 2b5f9a7 September 27, 2018 08:10

DIOHz0r added the hacktoberfest label Oct 1, 2018

Merge remote-tracking branch 'origin/develop' into feature/fdroid_2

d9f7d59

ajsb85 removed hacktoberfest labels Nov 1, 2018

ajsb85 closed this Dec 18, 2018

ajsb85 reopened this Dec 18, 2018

ajsb85 changed the base branch from develop to features/for_later December 18, 2018 00:17

btry closed this Dec 20, 2018

btry changed the base branch from features/for_later to develop December 20, 2018 17:41

btry reopened this Dec 20, 2018

ajsb85 assigned DIOHz0r and unassigned btry Dec 21, 2018

ajsb85 modified the milestones: 2.1, 3.0 Aug 8, 2019

Uh oh!

WIP F-Droid market #698

Are you sure you want to change the base?

WIP F-Droid market #698

Uh oh!

Conversation

btry commented Aug 21, 2018 • edited by DIOHz0r Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes description

Checklist

Estimated time

References

Uh oh!

DIOHz0r left a comment

Choose a reason for hiding this comment

Uh oh!

btry commented Aug 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Aug 22, 2018

Uh oh!

accesslint bot left a comment

Choose a reason for hiding this comment

Uh oh!

accesslint bot Aug 22, 2018

Choose a reason for hiding this comment

Uh oh!

ghost commented Aug 22, 2018

Uh oh!

btry commented Aug 22, 2018

Uh oh!

ghost commented Aug 22, 2018

Uh oh!

ghost commented Aug 23, 2018

Uh oh!

ghost commented Aug 24, 2018

Uh oh!

DIOHz0r commented Sep 25, 2018

Uh oh!

btry commented Sep 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

btry commented Aug 21, 2018 •

edited by DIOHz0r

Loading

btry commented Aug 21, 2018 •

edited

Loading