Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Fix flaky host summary tooltip test #24029

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Nov 21, 2024

Let's see if this is any better

  • Added/updated tests
  • Manual QA for all new/changed functionality

test-js (ubuntu-latest) SuccessCount / RunCount:
5/5 🎉


after merging main:
test-js (ubuntu-latest) SuccessCount / RunCount:
5/5
__

10/10 total 🎉🎉

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.17%. Comparing base (3b64f10) to head (b0031a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24029      +/-   ##
==========================================
- Coverage   63.42%   63.17%   -0.25%     
==========================================
  Files        1579     1562      -17     
  Lines      149950   148293    -1657     
  Branches     3782     3766      -16     
==========================================
- Hits        95106    93687    -1419     
+ Misses      47262    47208      -54     
+ Partials     7582     7398     -184     
Flag Coverage Δ
frontend 52.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

jacobshandling
jacobshandling previously approved these changes Nov 22, 2024
Copy link
Contributor

@jacobshandling jacobshandling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobshandling jacobshandling merged commit a680903 into main Nov 22, 2024
14 checks passed
@jacobshandling jacobshandling deleted the host-summary-flakey-test branch November 22, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants